Sema: Look through inout when mapping IUOs to Optionals. #13680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We translate IUOs to Optionals when generating signatures, but were failing to look through inout in the process, so we were allowing functions to be overloaded by Optional vs. IUO when the parameter was inout. Fixes https://bugs.swift.org/browse/SR-6685 / rdar://problem/36255630.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
I'm very unhappy with breaking source in this way, even if 97% of the time simply deleting the IUO overload is the right thing to do. |
|
Discussion happening here: https://bugs.swift.org/browse/SR-6690 |
|
As expected there's a failure on ObjectMapper in the source compatibility suite due to this change. |
Rather than error for overloading by the kind of optional (T? vs. T!) for inout parameters, just emit a warning for now and continue compiling. We'll need to turn this back into an error when we remove IUOs from the type system.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
Also add a note saying that allowing these overloads is deprecated and will be removed in a future release.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
This was referenced Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We translate IUOs to Optionals when generating signatures, but were
failing to look through inout in the process, so we were allowing
functions to be overloaded by Optional vs. IUO when the parameter was
inout.
Fixes https://bugs.swift.org/browse/SR-6685 / rdar://problem/36255630.