Skip to content

[stdlib] Free function + into static func + #13697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

[stdlib] Free function + into static func + #13697

merged 1 commit into from
Jan 4, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jan 3, 2018

No description provided.

@moiseev
Copy link
Contributor Author

moiseev commented Jan 3, 2018

/cc @xedin

@moiseev
Copy link
Contributor Author

moiseev commented Jan 3, 2018

@swift-ci Please test and merge

@moiseev
Copy link
Contributor Author

moiseev commented Jan 3, 2018

@swift-ci Please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Jan 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - fe48e8c

@moiseev
Copy link
Contributor Author

moiseev commented Jan 3, 2018

@swift-ci Please test macOS platform

@moiseev moiseev mentioned this pull request Jan 4, 2018
Merged
@moiseev moiseev merged commit 8246ce8 into swiftlang:master Jan 4, 2018
@moiseev moiseev deleted the static-func-ops-rrc branch January 4, 2018 19:24
@jrose-apple
Copy link
Contributor

Why are these on Sequence instead of RangeReplaceableCollection?

@xedin
Copy link
Contributor

xedin commented Jan 4, 2018

I concur with @jrose-apple - I think the only one which has to stay in Sequence is <Other : RangeReplaceableCollection>(Self, Other) (where Self is Sequence) but we can move the rest to RangeReplaceableCollection right?

@moiseev
Copy link
Contributor Author

moiseev commented Jan 4, 2018

Because I tried to put them all in extension RangeReplaceableCollection first and it introduced an ambiguity 🤷‍♂️, that is avoided with this approach.

@moiseev
Copy link
Contributor Author

moiseev commented Jan 4, 2018

To me it seems more logical to group S -> RRC -> RRC and RRC -> S -> RRC together.

@jrose-apple
Copy link
Contributor

Putting them on RRC may actually be more efficient if we ever get to change how operator lookup works, so it might be worth investigating that ambiguity.

@moiseev moiseev mentioned this pull request Jan 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moiseev @swift-ci @jrose-apple @xedin