[Runtime] Improvements to foreign class metadata #13704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
Like other nominal type metadata, include a nominal type descriptor in foreign class metadata.
When emitting foreign class metadata (e.g., for an imported CF type), fill in the superclass when we have one. The superclass will itself be a foreign metadata candidate, so also register an initialization function that uniques the superclass metadata once we've picked the canonical foreign class metadata.
DougGregor
force-pushed
the
runtime-foreign-class-metadata
branch
from
28789b4 to
12a774a
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve foreign class metadata in a few ways: