Skip to content

Revert "[Coverage] Clean up a few classes, NFC" #13709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Jan 4, 2018

Reverts #13705

It looks like this is required in order to revert #13597, which appears to have resulted in some source compatibility suite builds to break.

See: https://ci.swift.org/job/swift-master-source-compat-suite/1014/

@rudkx
Copy link
Contributor Author

rudkx commented Jan 4, 2018

@swift-ci Please smoke test

@rudkx
Copy link
Contributor Author

rudkx commented Jan 4, 2018

I'll hold off on this pending #13711.

@vedantk
Copy link
Contributor

vedantk commented Jan 4, 2018

I think #13711 resolves the source compatibility issues caused by #13597, but testing shows some unrelated failures which I don't have time to investigate tonight. I'll go ahead and merge this (revert #13705) and revert #13597 to unblock the bots.

@vedantk vedantk merged commit 78d993a into master Jan 4, 2018
@rudkx rudkx deleted the revert-13705-master branch January 4, 2018 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants