Bump the compiler version to 4.2 (and 3.4) #13767
Conversation
|
cc @aciidb0mb3r |
|
@swift-ci Please test |
|
Thanks Jordan! |
|
Build failed |
|
This looks OK to me. Should we just go straight to 5.0 now? |
|
Bah, missed a test. Uh, it's probably okay to go straight to 5 but I wonder at what point we're going to discuss the testing strategy. (The tests are mostly still run in Swift 3 mode unless specified otherwise because they were a corpus of Swift 3 code.) |
|
There's also "get the compiler to advertise itself as Swift 5" vs. "change the default when you omit -swift-version" and those don't have to be in sync…but it makes more sense when they are. |
Whether there's going to be an actual 4.2 release or we go straight to 5.0, we're not 4.1 anymore.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Since #13843 didn't quite go cleanly and I haven't had time to look at it, can we merge this in the mean time? |
|
@swift-ci Please smoke test |
| @@ -40,7 +40,7 @@ | |||
| CMAKE_GENERATOR = 'Ninja' | |||
|
|
|||
| COMPILER_VENDOR = 'none' | |||
| SWIFT_USER_VISIBLE_VERSION = CompilerVersion('4.1') | |||
| SWIFT_USER_VISIBLE_VERSION = CompilerVersion('4.2') | |||
| CLANG_USER_VISIBLE_VERSION = CompilerVersion('5.0.0') | |||
There was a problem hiding this comment.
This default is very suspicious. Shouldn't we be getting it from the Clang repository somehow? cc @Rostepher
|
Per https://swift.org/blog/4-2-release-process/, this is the right one to commit now, right @tkremenek? @swift-ci Please smoke test |
|
Yes |
Whether there's going to be an actual 4.2 release or we go straight to 5.0, we're not 4.1 anymore.