check-swift-only_executable: Mark executable tests as such #13825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
I'm not sure this is right for JIT tests. Those seem like yet another category, potentially—while they shouldn't be run under only_non_executable, they also aren't being optimized under only_executable. @lhames, thoughts? |
aschwaighofer
force-pushed
the
mark_some_executable_tests_as_such
branch
from
ec97eee to
de66079
Compare
|
@swift-ci Please smoke test |
|
Late to the party. If 'executable_test' means you need to be able to execute code in the environment I think it's reasonable to disable JIT tests in non-executable mode, at least for now. I'm planning to revisit the interpreter design in the near future -- we can re-evaluate this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executable tests need to be marked with 'REQUIRES: executable_test' for check-swift-only_executable and check-swift-only_non_executable to work.