Skip to content

[build-script] Stop expanding argument symlinks #13886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

Rostepher
Copy link
Contributor

Purpose

Stop expanding symlinks in paths, since an absolute path is likely the right choice.

rdar://36447266

@Rostepher
Copy link
Contributor Author

I ran my unit-test suite locally for the build_swift python package, everything passed.

@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rostepher
Copy link
Contributor Author

Merging now that the tests have passed and it works on the 5.0 branch.

@Rostepher Rostepher merged commit ce8fb62 into swiftlang:master Jan 16, 2018
@Rostepher Rostepher deleted the unreal-argument-pathways branch January 16, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants