[cast-optimizer] Move the cast optimizer into its own .cpp file. #13932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
|
Oops. Hit that a bit too fast. Sorry! It will fail. |
gottesmm
force-pushed
the
pr-f7d51d76d90c593b876ea658427a26fbadd64ba2
branch
from
dce880d to
30be03b
Compare
Local.cpp was ~3k lines of which 1.5k (i.e. 1/2) was the cast optimizer. This commit extracts the cast optimizer into its own .cpp and .h file. It is large enough to stand on its own and allows for Local.cpp to return to being a small group of helper functions. I am making some changes in this area due to the change in certain function conventions caused by the +0-normal-arg work. I am just trying to leave the area a little cleaner than before.
gottesmm
force-pushed
the
pr-f7d51d76d90c593b876ea658427a26fbadd64ba2
branch
from
30be03b to
dfd40e4
Compare
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local.cpp was ~3k lines of which 1.5k (i.e. 1/2) was the cast optimizer. This
commit extracts the cast optimizer into its own .cpp and .h file. It is large
enough to stand on its own and allows for Local.cpp to return to being a small
group of helper functions.
I am making some changes in this area due to the change in certain function
conventions caused by the +0-normal-arg work. I am just trying to leave the area
a little cleaner than before.