[ClangImporter] Handle diagnostics about cast types in macros #13972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The importer handles these by first trying to look up the type by name using Clang's Sema, but that lookup can cause diagnostics to be emitted (usually availability diagnostics). We could try to figure out how to propagate that to the macro when we import it, but for now just drop the macro instead if there are any diagnostics emitted when looking up the type. This will be a small source compatibility break if anyone was using a macro defined in terms of a type that's deprecated or that has partial availability; the macro will now silently not be imported instead of producing an unsilenceable warning. rdar://problem/36528212
|
Since this is a well-defined, isolated source compatibility break that's independent of already-discussed language features, the core team has to review it, right? @DougGregor, @rjmccall, how do you want to handle that? |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
I don't think we want a full review process, but it would be nice if these "mini tweaks" were at least documented somewhere. Perhaps CHANGELOG.md? |
Hey, it's the first Swift 5 changelog note.
|
(Both the regular test and the source compat suite passed already.) @swift-ci Please smoke test |
|
Merged ahead of any such discussion to clear out some warnings on internal Apple bots. We can revisit if the core team decides this is unacceptable. |
|
I think that's reasonable. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jan 23, 2018
[ClangImporter] Handle diagnostics about cast types in macros (cherry picked from commit 59ceb22)
jrose-apple
added a commit
that referenced
this pull request
Jan 23, 2018
[ClangImporter] Handle diagnostics about cast types in macros (cherry picked from commit 59ceb22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The importer handles these by first trying to look up the type by name using Clang's Sema, but that lookup can cause diagnostics to be emitted (usually availability diagnostics). We could try to figure out how to propagate that to the macro when we import it, but for now just drop the macro instead if there are any diagnostics emitted when looking up the type.
This will be a small source compatibility break if anyone was using a macro defined in terms of a type that's deprecated or that has partial availability; the macro will now silently not be imported instead of producing an unsilenceable warning.
rdar://problem/36528212