[Syntax] Unify RawSyntax and RawTokenSyntax using union and TrailingObjects #13990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please ASAN test |
|
@swift-ci Please smoke test |
nkcsgexi
reviewed
Jan 17, 2018
| } | ||
| size_t numTrailingObjects(OverloadToken<TriviaPiece>) const { | ||
| return isToken() ? Bits.NumLeadingTrivia + Bits.NumTrailingTrivia : 0; | ||
| } |
There was a problem hiding this comment.
Not a super big deal but we shouldn't need to define numTrailingObjects for the last trailing object type. It will never get called.
There was a problem hiding this comment.
Yeah, but I'd rather keep this so we can see how we calculate the number of trailing objects.
rintaro
force-pushed
the
syntax-rawsyntax-union
branch
from
fb603bd to
ce8c701
Compare
|
@swift-ci Please smoke test |
…bjects It better matches with SwiftSyntax model. Using TrailingObjects reduces the number of heap allocation which gains 18% performance improvement.
rintaro
force-pushed
the
syntax-rawsyntax-union
branch
from
ce8c701 to
0780c52
Compare
|
@swift-ci Please smoke test |
rintaro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It better matches with
SwiftSyntaxmodel.Also, using
TrailingObjectsreduces the number of heap allocation. This gains about 18% performance improvement in libSyntax parsing.