[Batch mode] Move various Frontend pieces into dedicated files. #14001
Conversation
|
@swift-ci please smoke test os x platform |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
davidungar
force-pushed
the
PR-18-3a
branch
2 times, most recently
from
de30931 to
5883d02
Compare
|
@swift-ci please smoke test |
include/swift/Basic/InputFile.h
Outdated
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors |
There was a problem hiding this comment.
Yup. What about existing files? Should I update the dates in the future whenever I change one?
include/swift/Basic/InputFile.h
Outdated
| //===----------------------------------------------------------------------===// | ||
|
|
||
|
|
||
| #ifndef InputFile_h |
There was a problem hiding this comment.
Please use the same header guard style as the other headers: SWIFT_BASIC_INPUTFILE. (Also, why is this in Basic instead of Frontend?)
There was a problem hiding this comment.
Fixed in all my new files. Moved from Basic to Frontend. (Had thought other parts of the compile would need that class, but at least they don't yet.)
| @@ -0,0 +1,127 @@ | |||
| //===--- FrontendInputs.h -------------------------------------------------===// | |||
There was a problem hiding this comment.
Missing the -*- c++ -*- for the emacs folks.
There was a problem hiding this comment.
Supplied that for all my new files.
lib/Frontend/FrontendInputs.cpp
Outdated
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "swift/Frontend/FrontendOptions.h" |
There was a problem hiding this comment.
The first include in a .cpp file should always be the corresponding header file, both to show which header is "corresponding" and to provide a small check that that header works standalone.
There was a problem hiding this comment.
Fixed in all my new files. Put a blank line after that include following what seemed to be a convention I saw elsewhere.
| @@ -21,7 +22,7 @@ | |||
|
|
|||
| #include <vector> | |||
|
|
|||
| using namespace swift; | |||
| using namespace swift; | |||
There was a problem hiding this comment.
Stray indentation here.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
| #include "llvm/Option/ArgList.h" | ||
|
|
||
| using namespace swift; | ||
| using namespace llvm::opt; |
There was a problem hiding this comment.
Oops, sorry. No using namespace in headers, please (here and elsewhere).
lib/Frontend/CompilerInvocation.cpp
Outdated
| @@ -10,9 +10,11 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #include "swift/Frontend/Frontend.h" | |||
There was a problem hiding this comment.
I think this one can stay, since it's the main header for the file despite not having the same name.
|
@swift-ci please smoke test |
| @@ -0,0 +1,98 @@ | |||
| //=== = ---ArgsToFrontendOptionsConverter.h-- -----------------*-C++ - * -=== // | |||
There was a problem hiding this comment.
This is really nitpicky but the first line of this got messed up somehow.
|
@swift-ci please smoke test |
No description provided.