Skip to content

[IRGen] Fix some is-stable-ABI marker bits. #14004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2018
Merged

[IRGen] Fix some is-stable-ABI marker bits. #14004

merged 3 commits into from
Jan 19, 2018

Conversation

gparker42
Copy link
Contributor

  • Don't emit "stable ABI masquerading as legacy ABI" bit state yet.
  • Don't unconditionally emit bit value 1 in generic class templates.

rdar://36612173

[IRGen] Fix some is-stable-ABI marker bits.
1fc6228 
* Don't emit "stable ABI masquerading as legacy ABI" bit state yet.
* Don't unconditionally emit bit value 1 in generic class templates.

rdar://36612173
@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1fc6228

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1fc6228

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1fc6228

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1fc6228

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1bca754

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1bca754

@gparker42 gparker42 merged commit 91bcf1e into swiftlang:master Jan 19, 2018
@gparker42 gparker42 deleted the GrP-PR-C47E82FD-D8EF-4E78-BF04-1DF01C8E87C5 branch January 19, 2018 07:24
@gparker42 gparker42 restored the GrP-PR-C47E82FD-D8EF-4E78-BF04-1DF01C8E87C5 branch January 19, 2018 07:27
gparker42 pushed a commit to gparker42/swift that referenced this pull request Jan 19, 2018
[IRGen] Fix some is-stable-ABI marker bits. (swiftlang#14004)
3a9320a 
* Don't emit "stable ABI masquerading as legacy ABI" bit state yet.
* Don't unconditionally emit bit value 1 in generic class templates.

rdar://36612173
gparker42 pushed a commit to gparker42/swift that referenced this pull request Jan 19, 2018
[IRGen] Fix some is-stable-ABI marker bits. (swiftlang#14004)
902d793 
* Don't emit "stable ABI masquerading as legacy ABI" bit state yet.
* Don't unconditionally emit bit value 1 in generic class templates.

rdar://36612173
@gparker42 gparker42 deleted the GrP-PR-C47E82FD-D8EF-4E78-BF04-1DF01C8E87C5 branch January 19, 2018 09:49
@gparker42
Copy link
Contributor Author

5.0 branch: #14022

gparker42 pushed a commit that referenced this pull request Jan 19, 2018
[IRGen] Fix some is-stable-ABI marker bits. (#14004) (#14022)
8c3bf56 
* Don't emit "stable ABI masquerading as legacy ABI" bit state yet.
* Don't unconditionally emit bit value 1 in generic class templates.

rdar://36612173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gparker42 @swift-ci