Skip to content

[4.1] EscapeAnalysis: update use-points for nodes which are created on dema… #14037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

eeckstein
Copy link
Contributor

…nd after the use-point info is already calculated.

fixes rdar://problem/36450027

…nd after the use-point info is already calculated.

fixes rdar://problem/36450027
@eeckstein
Copy link
Contributor Author

@swift-ci test

@atrick atrick self-requested a review January 21, 2018 01:49
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this for CCC.

@eeckstein
Copy link
Contributor Author

Explanation: This bug can cause a miscompile because it can result in wrong alias information. In this case it let loop-invariant-codemotion hoist a load which should not be hoisted.
Scope: The bug is in the compiler since a very long time. Essentially since we introduced escape analysis. It's a rare case and therefore it didn't show up until now.
Risk: Low. The single-line change only makes escape analysis more conservative.
Testing: Swift CI Tests added.
Reviewed by: Andy

rdar://problem/36450027

@eeckstein eeckstein merged commit f2de002 into swiftlang:swift-4.1-branch Jan 22, 2018
@eeckstein eeckstein deleted the fix-ea-4.1 branch January 22, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants