[runtime] Reinstate TwoWordPair hack for swiftcall returns. #14079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang is miscompiling some swiftcall functions on armv7s. Stop using swiftcall in some places until it is fixed. Reverts c5bf2ec (swiftlang#13299). rdar://35973477
|
@swift-ci please test |
|
Do we expect this to be a long-term issue - is it worth trying to find another workaround for Windows in the meantime? |
|
I don't think clang is doing anything wrong here. Rather I believe the original TwoWordPair removal patch was missing |
|
Yep, it's not a miscompile after all. We should be able to get a fix soon. |
gparker42
pushed a commit
to gparker42/swift
that referenced
this pull request
Jan 24, 2018
…g#14079) clang is miscompiling some swiftcall functions on armv7s. Stop using swiftcall in some places until it is fixed. Reverts c5bf2ec (swiftlang#13299). rdar://35973477
troughton
added a commit
to troughton/swift
that referenced
this pull request
Jan 27, 2018
…wiftlang#14079)" This reverts commit 7b92247.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang is miscompiling some swiftcall functions on armv7s.
Stop using swiftcall in some places until it is fixed.
Reverts c5bf2ec (#13299).
rdar://35973477