[4.1] [SR-5022] Diagnose an invalid use of non-polymorphic constructors #14097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b217d36)
(cherry picked from commit 71afed8)
…etype This is a corner case but would previously lead to a compiler crash or miscompile. Fixes <rdar://problem/21991470>, <https://bugs.swift.org/browse/SR-5022>. (cherry picked from commit 336a97b)
|
@swift-ci please test |
|
@swift-ci please nominate |
DougGregor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Explanation: Diagnoses an invalid uses of non-polymorphic constructors, which (if undiagnosed) would cause a crash later in the ripely.
• Scope of Issue: Correctly rejects invalid code that would have crashed the compiler later.
• Origination: N/A
• Risk: Low risk; we would have crashed on this code anyway.
• Reviewed By: @jrose-apple
• Testing: Compiler regression tests.
• Radar / SR: rdar://problem/21991470, SR-5022