[4.1] [ClangImporter] Handle ns_error_domain on nameless enums with typedefs #14108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't come up when using the NS_ERROR_ENUM macro, but it shouldn't crash the compiler, and it was easy enough to fix. rdar://problem/36799009 (cherry picked from commit 138304a)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ns_error_domain,enum_extensibility, orflag_enumClang attributes on an anonymous C enum that's immediately given a name via a typedef led to an assertion failure. In no-asserts builds, I suspect the enum elements weren't properly prefix-stripped, but I don't actually have such a build around to check. These enums are rare but that doesn't mean we shouldn't support them, and we ran into one in an Apple-internal project.