Skip to content

[4.1] IRGen: Set artifical functions for key path code #14115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2018
Merged

[4.1] IRGen: Set artifical functions for key path code #14115

merged 1 commit into from
Jan 24, 2018

Conversation

aschwaighofer
Copy link
Contributor

Otherwise, debug info asserts get triggered because of a missing debug
loc.

rdar://36797675

  • Explanation: Keypath IRGen code was missing calls to set an artificial debug location. Causing an assert in asserts builds when compiling code with -g.
  • Scope: Change localized to key path implementation functions.
  • Risk: Low. Added code to set an artificial debug location
  • Testing: Added Swift CI test

@aschwaighofer
[4.1] IRGen: Set artifical functions for key path code
7219615 
Otherwise, debug info asserts get triggered because of a missing debug
loc.

rdar://36797675
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test source compatibility

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please nominate

@aschwaighofer aschwaighofer merged commit 41ca788 into swiftlang:swift-4.1-branch Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aschwaighofer