Skip to content

[4.1] Do not assert on @objc (Name) extension FancyName {} #14119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2018
Merged

[4.1] Do not assert on @objc (Name) extension FancyName {} #14119

merged 1 commit into from
Jan 24, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Jan 24, 2018 •
edited
Loading

  • Explanation: We crash on @objc (Name) extension ... despite having accepted this in previous releases.
  • Scope: Small. A missing conditional check results in executing code that we shouldn't.
  • Origination: We're hitting an assert that we also hit with swift-4.0-branch but which does not cause a crash in a release build. This probably originated with the implementation of [SE-160].
  • Risk: Very small. Avoids a code path where we assert.
  • Bug: rdar://problem/36798061
  • Reviewed by: Doug Gregor
  • Testing: Regression tests including new test case.

@rudkx
Do not crash on @objc (Name) extension FancyName {}
7146454 
We accepted this in Xcode 9.2, but currently crash.

We may want to consider rejecting this entirely, but for now lets not
crash.

Fixes rdar://problem/36798061.

(cherry picked from commit a499762)
@rudkx rudkx requested a review from DougGregor January 24, 2018 05:53
@rudkx rudkx changed the title Do not crash on @objc (Name) extension FancyName {} [4.1] Do not crash on @objc (Name) extension FancyName {} Jan 24, 2018
@rudkx
Copy link
Contributor Author

rudkx commented Jan 24, 2018

@swift-ci Please test

@rudkx rudkx changed the title [4.1] Do not crash on @objc (Name) extension FancyName {} [4.1] Do not assert on @objc (Name) extension FancyName {} Jan 24, 2018
@rudkx
Copy link
Contributor Author

rudkx commented Jan 24, 2018

@swift-ci Please nominate

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7146454

@rudkx
Copy link
Contributor Author

rudkx commented Jan 24, 2018

Timeout on macOS.

@rudkx
Copy link
Contributor Author

rudkx commented Jan 24, 2018

@swift-ci Please test OS X platform

@rudkx rudkx merged commit f1ba749 into swiftlang:swift-4.1-branch Jan 24, 2018
@rudkx rudkx deleted the rdar36798061-4.1 branch January 24, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudkx @swift-ci