Skip to content

[Mangled name -> metadata] Add built-in types support #14125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2018
Merged

[Mangled name -> metadata] Add built-in types support #14125

merged 3 commits into from
Jan 24, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 24, 2018

Includes changes to make list of built-in types meta-programmable, and makes use of in the Demangle when we convert opaque metadata into demangling tree and mangled name -> metadata.

@xedin xedin requested a review from DougGregor January 24, 2018 08:32
@xedin
Copy link
Contributor Author

xedin commented Jan 24, 2018

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jan 24, 2018

@DougGregor please take a look! Only Builtin.RawPointer is missing from the tests, because metadata returns Any.Type = Builtin.RawPointer but Builtin.RawPointer.self points either to Builtin.Int32.Type or Builtin.Int64.Type depending on the platform, so I couldn't figure out how to validate that in the test.

@xedin xedin merged commit b1251b3 into swiftlang:master Jan 24, 2018
@xedin
Copy link
Contributor Author

xedin commented Jan 24, 2018

Talked with @DougGregor offline and he is ok with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xedin