[4.1] [test] Fix Interpreter/class_resilience.swift to test the right thing #14141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Jan 25, 2018
jrose-apple
commented
- Explanation: This test wasn't testing what it was supposed to be testing, and as such it would fail in rare circumstances when run on an iOS device (using Apple's internal on-device testing tool).
- Scope: Test change only
- Issue: rdar://problem/36830081
- Reviewed by: @aschwaighofer
- Risk: None
- Testing: Manually verified the failure and fix on my own iOS device.
…swiftlang#14136) ...and to not fail when the Apple-internal on-device testing tool decided to clear out unused files. rdar://problem/36830081 (cherry picked from commit 52e6c1f)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.