[WIP] Nothing to see here...IUO changes. #14150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…O attr on decl."" This reverts commit c773493. This was reverted from master when we added back some extensions to ImplicitlyUnwrappedOptional<T>, but these changes are fine in a world in which IUOs are implemented as Optional<T>.
…ObjectiveCBridgeable." This reverts commit be6d83c. We can remove these again since ImplicitlyUnwrappedOptional<T> is going away.
Stop creating ImplicitlyUnwrappedOptional<T> so that we can remove it from the type system. Enable the code that generates disjunctions for Optional<T> and rewrites expressions based on the original declared type being 'T!'. This effectively means ImplicitlyUnwrappedOptional<T> is no longer part of the type system, although I haven't actually removed all of the code dealing with it yet. Most of the changes supporting this were previously merged to master, but some things, like support for dynamic lookup were difficult to put on master without actually removing IUOs. ImplicitlyUnwrappedOptional<T> is is dead, long live implicitly unwrapped Optional<T>! Resolves rdar://problem/33272674.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Failures expected... |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
In addition to the expected failure in ObjectMapper (which will be XFAILed by swiftlang/swift-source-compat-suite#127), it looks like SwiftLint is has a dependency on a version of SourceKitten that does not include jpsim/SourceKitten@8c92b0c, so it is also failing. |
|
@swift-ci Please test Linux platform |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just testing out some of the not-yet-merged IUO changes including some hacked up parameter matching code that will probably be rewritten.