[4.1][CursorInfo] Fix crash on init call of inner class with outer generic context

[nathawes]

CCC Info

• Radar: rdar://problem/35819975
• Explanation:

Invoking the cursor info request on a call to the initializer of an inner class in a generic context would crash SourceKit, e.g:

class Bar<T> {
  class Inner {}
  func foo() { /*invoke here:*/Inner() }
}

There was faulty logic to treat an invocation on an initializer call, e.g. Inner(), as if it were a plain reference to the type, e.g. Inner. We were updating the declaration used to the initializer's parent, but left the containing type as is.

• Risk: Low. Change only affects sourcekitd cursor info request when invoked on initializer calls.
• Scope of issue: Jump-to-definition, quick help and refactoring were crashing sourcekit on these initializer calls
• Origination: CrashTracer issue
• Reviewed by: Xi Ge
• Testing: Added regression test

[nathawes]

@swift-ci please test

[nkcsgexi]

LGTM.

[nathawes]

@swift-ci please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - f3602e6aebdb47f51391d1a9516a32420e969bf3

[nathawes]

@swift-ci please test

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - f3602e6aebdb47f51391d1a9516a32420e969bf3

[nathawes]

@swift-ci please test linux