SwiftSyntax: Single out an API to deserialize SourceFileSyntax. NFC #14164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since our recent integration with SourceKit, clients may get a SourceFileSyntax in a serialized form from SourceKit response. We need an API in the SwiftSyntax framework to decode this form. This'll be a more common pattern to get a Swift side syntax tree than invoking swiftc internally.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
I can't overstate how much better using SourceKit is than invoking |
harlanhaskins
approved these changes
Jan 25, 2018
|
@swift-ci please smoke test |
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
… NFC (swiftlang#14164) Since our recent integration with SourceKit, clients may get a SourceFileSyntax in a serialized form from SourceKit response. We need an API in the SwiftSyntax framework to decode this form. This'll be a more common pattern to get a Swift side syntax tree than invoking swiftc internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our recent integration with SourceKit, clients may get a SourceFileSyntax
in a serialized form from SourceKit response. We need an API in the
SwiftSyntax framework to decode this form. This'll be a more common
pattern to get a Swift side syntax tree than invoking swiftc internally.