[Foundation] Address a potential leak when writing a data to a URL and the file system representation fails #14176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the file system representation fails
|
@swift-ci please smoke test |
|
@phausler Is it possible for you to make a test case that goes down that path? I will see if I can jerry-rig something for you vis-a-vis the leaks checking. |
|
I have a hunch on how to trigger it but it will require some subclassing shenanigans with NSURL. From what I can tell this cannot happen on Darwin platforms with properly constructed urls. |
|
Ok. Nm then. |
parkera
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://problem/36889982