Skip to content

[4.1] Fix "variable unused" warning in Metadata.cpp in non-assert build #14225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2018
Merged

[4.1] Fix "variable unused" warning in Metadata.cpp in non-assert build #14225

merged 2 commits into from
Feb 8, 2018

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek kubamracek requested a review from rjmccall January 28, 2018 18:09
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek changed the title Use '(void)' in Metadata.cpp to avoid "variable unused" warning in non-assert builds. [4.1] Use '(void)' in Metadata.cpp to avoid "variable unused" warning in non-assert builds. Jan 28, 2018
@gparker42
Copy link
Contributor

Should we instead change this to assert(numPatternWitnesses >= protocol->NumMandatoryRequirements); and just drop the unused variable?

@kubamracek
Copy link
Contributor Author

Sure, if you prefer that.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek requested a review from gparker42 February 6, 2018 15:08
@kubamracek kubamracek changed the title [4.1] Use '(void)' in Metadata.cpp to avoid "variable unused" warning in non-assert builds. [4.1] Fix "variable unused" warning in Metadata.cpp in non-assert build Feb 6, 2018
@swift-ci
Copy link
Contributor

swift-ci commented Feb 6, 2018

Build failed
Swift Test Linux Platform
Git Sha - 979fd61

@swift-ci
Copy link
Contributor

swift-ci commented Feb 6, 2018

Build failed
Swift Test OS X Platform
Git Sha - 979fd61

@kubamracek
Copy link
Contributor Author

ping

rjmccall
rjmccall approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is fine, of course.

@kubamracek kubamracek merged commit 5cbecbd into swiftlang:swift-4.1-branch Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmccall rjmccall rjmccall approved these changes

@gparker42 gparker42 Awaiting requested review from gparker42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubamracek @gparker42 @swift-ci @rjmccall