Revert "[stdlib] Add custom implementations of removeLast and remove(at:) to Array" #14231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at:) to Array (swiftlang#14212)" This reverts commit 5ed4afe. It doesn't appear to be correct when the client is compiled with optimizations (as in, there's a failing bot).
|
@swift-ci Please smoke test and merge |
|
Rats. |
|
It does look right, so it's also possible there's an optimizer bug somewhere… |
|
I think so. The failure is only happening specifically on an optimize build with the debug std lib and I can't see how it can be an unsafe memory error since it's the count that must be wrong. But at least I can repro it locally now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #14212. It doesn't appear to be correct when the client is compiled with optimizations (as in, there's a failing bot).