[4.1] SIL : Use the enum 's generic signature and the payloads type f… #14234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or an indirect enum payload's box type.
i.e for:
enum Indirect<T> {
indirect cast payload(first: T, second :T)
}
let _ = Indirect<X>
The payload's SIL box type will be:
$<t_0_0> { var (first: t_0_0, second: t_0_0) } <X>
rdar: //36799330
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
@swift-ci please nominate |
|
@shahmishal @najacque Nominate seems to be down. |
|
@swift-ci please nominate |
|
The source compat failures are the same 11 failures that are also on the current swift-4.1-branch: |
|
swift-5.0-branch merged: #14235 |
|
@swift-ci please nominate |
|
@aschwaighofer I'm investigating the nomination issue. |
|
@najacque Thanks. I have manually nominated this in the meantime. |
|
@aschwaighofer I found the issue -- you had a space in your radar URL, so it wasn't recognized as valid. |
|
@najacque Oh. Ok thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or an indirect enum payload's box type.
i.e for:
enum Indirect {
indirect cast payload(first: T, second :T)
}
let _ = Indirect
The payload's SIL box type will be:
$<t_0_0> { var (first: t_0_0, second: t_0_0) }
rdar: //36799330
Explanation: We were lowering SIL box types for enums as a generic field without copying the enum's payloads field type to the field type we used for the box. This resulted in lowered types ending up in the substitution list of the box causing assertion failures in the SIL verifier when we specialized closure types into the enum.
Scope: This issue has been there since modeling SIL box types where introduced AFAICT.
Risk: Low. Only affects indirect enum types.
Reviewed: Joe Groff
Testing: Swift CI test added. Verified that failing project compiles successfully with this change.