[5.0] Allow inout arguments that differ in optionality than the expected pa… #14246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rudkx
changed the title
…rameter. Allow passing Optional<T> as inout where ImplicitlyUnwrappedOptional<T> is expected, and vice-versa. Swift 4.1 added a warning that overloading inouts by kind of optional was deprecated and would be removed, but we didn't actually allow people to remove an overload and pass arguments of the other kind of optional to the remaining function. Fixes rdar://problem/36913150 (cherry picked from commit 8685ee0)
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rameter.
Allow passing Optional as inout where
ImplicitlyUnwrappedOptional is expected, and vice-versa.
Swift 4.1 added a warning that overloading inouts by kind of optional
was deprecated and would be removed, but we didn't actually allow
people to remove an overload and pass arguments of the other kind of
optional to the remaining function.
Fixes rdar://problem/36913150
(cherry picked from commit 8cd99ebe722d709fb99e2320348f29e895fa4037)