Skip to content

[SourceKit] Report synthesized protocol conformances for DocSupport request. rdar://36882292 #14248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2018
Merged

Conversation

nkcsgexi
Copy link
Contributor

No description provided.

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

@jrose-apple please notice the doc-info request doesn't report any protocol conformances on MyNSStringEnum. When you've fixed the root cause, the test should fail.

@jrose-apple
Copy link
Contributor

It turned out not to be the same issue after all, sorry. :-(

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

@jrose-apple thanks for letting me know!

@nkcsgexi nkcsgexi changed the title [test][SourceKit] Add a test case for missing reported conformances on NS_STRING_ENUM. rdar://36882292 [SourceKit] Report synthesized protocol conformances for DocSupport request. rdar://36882292 Jan 30, 2018
@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi nkcsgexi merged commit 9857055 into swiftlang:master Jan 30, 2018
@nkcsgexi nkcsgexi deleted the test-doc-support branch January 30, 2018 21:32
@jrose-apple
Copy link
Contributor

Ah, that makes sense! Retroactive whoops, glad the fix was straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants