-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Add custom implementations of removeLast and remove(at:) to Array #14273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please smoke benchmark |
@swift-ci please test |
Build comment file:Optimized (O)Regression (21)
Improvement (10)
No Changes (324)
Unoptimized (Onone)Regression (61)
Improvement (10)
No Changes (284)
Hardware Overview
|
@lancep @jrose-apple I still can't reproduce the original problem. I'm hoping it was a miscompile and this doesn't have the same issue, but if I'm wrong, we can insta-revert. But if this goes through, I can file the other one as a jira for the optimizer. |
The original problem came up when running the test suite with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another go at #14212, this time without sharing of code between
removeLast
andpopLast
(which also means avoiding duplicate checks)