[5.0] Fix build by changing test to only run on macOS. #14275
Merged
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason why this snuck through before is that we are not building asan on the public bots for simulators. I am going to look into tightening this up, but in the short term, lets get some green builds. rdar://36916944
gottesmm
force-pushed
the
swift-5.0-branch_rdar36916944
branch
from
a151dd0 to
a78fed1
Compare
|
@swift-ci test |
|
I just confirmed with Bob that Jordan's review from 4.1 is sufficient for 5.0 as well. I am going to let this finish testing and then send this PR to the CCC list. |
|
The 4.1 variant of this is #14238. |
|
Build failed |
|
The playground logger failure is not me. I just emailed @cwakamo about this. |
|
@swift-ci test os x platform |
|
Build failed |
|
@swift-ci test os x platform |
|
Build failed |
|
Same playground failure. Maybe I tried too soon before the fix was merged. Trying again... |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why this snuck through before is that we are not building asan on the
public bots for simulators. I am going to look into tightening this up, but in
the short term, lets get some green builds.
rdar://36916944