Skip to content

Don't use SmallVector in MetadataReader. #14282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2018
Merged

Don't use SmallVector in MetadataReader. #14282

merged 1 commit into from
Jan 30, 2018

Conversation

jckarter
Copy link
Contributor

Not all of its clients link in the necessary LLVM support libraries.

@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test

@jckarter
Don't use SmallVector in MetadataReader.
f35cb9d 
Not all of its clients link in the necessary LLVM support libraries.
@jckarter jckarter force-pushed the no-smallvector-in-metadata-reader branch from 0fa3f3d to f35cb9d Compare January 30, 2018 20:31
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0fa3f3d608b0f7b387242766c2bcf1c3f5526f4f

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0fa3f3d608b0f7b387242766c2bcf1c3f5526f4f

@gottesmm
Copy link
Contributor

I thought SmallVector was header only.

@jckarter jckarter merged commit 60b55c3 into swiftlang:master Jan 30, 2018
@jckarter
Copy link
Contributor Author

Parts of SmallVectorImpl are in the binary, as is the report_bad_alloc callback for allocation failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jckarter @swift-ci @gottesmm