WIP/IRGen: PCS for ARM VFP CC does not correctly handle HFAs #14304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When materializing the implicit constructor containing a HFA, the VFP CC will result in an incorrect attempt to coerce parameters to the structure type. This causes an assertion in LLVM as we attempt to store a structure by value into an alloca.
|
#15174 is more complete and supersedes this. |
|
Oops, wrong PR |
|
Looks like this is just a test update now? Besides CI testing, is anything needed to merge this? |
|
I don't know if the underlying issue has been resolved. I think it would be good to check that, and we can decide to merge it with an XFAIL I suppose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When materializing the implicit constructor containing a HFA, the VFP CC
will result in an incorrect attempt to coerce parameters to the
structure type. This causes an assertion in LLVM as we attempt to store
a structure by value into an alloca.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.