[build system] Speculative Apple lld fix #14306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
bob-wilson
added a commit
to bob-wilson/swift
that referenced
this pull request
May 5, 2018
PR swiftlang#14306 fixed the problem in https://bugs.swift.org/browse/SR-6878 but included a comment about mysterious behavior on macOS. I did some investigation and found that Clang assumes that Darwin platforms use a different name for LLD. My impression is that LLD is not yet ready for prime time on Darwin, so leaving it disabled for Apple platforms seems like the right thing for now. This just updates the comments to explain what will need to change whenever someone wants to reenable it. rdar://problem/37053028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.