[5.0][stdlib] Set, Dictionary: Take the max load factor into account in .init(minimumCapacity:) #14341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in .init(minimumCapacity:) rdar://problem/36619317 (cherry picked from commit 34bda52)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Explanation: Set, Dictionary.init(minimumCapacity:) did not allocate enough storage to actually hold the requested number of items.
• Scope of Issue: Mostly a performance issue; it results in one unexpected storage reallocation while elements are added to the collection.
• Origination: It looks like this has been like this forever.
• Risk: Low risk. Increasing allocated capacity is unlikely to break code.
• Reviewed By: @natecook1000
• Testing: Stdlib regression tests, including new tests.
• Radar / SR: rdar://problem/36619317