[stdlib] Collection compatibility shim fixes #14342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test and merge |
airspeedswift
commented
Feb 1, 2018
|
|
||
| CollectionDistance.test("Int16/advance") { | ||
| let c = MyCollection<Int>(_elements: [1,2,3]) | ||
| let d: Int16 = 1 |
There was a problem hiding this comment.
Note, these shims can't be constrained to the specific old IndexDistance type, they'll work with any integer type.
|
@swift-ci please test linux platform |
airspeedswift
added a commit
to airspeedswift/swift
that referenced
this pull request
Feb 6, 2018
* Fix compatibility shims for IndexDistance * Add a second test for implied IndexDistance, Bidirectional conformance
airspeedswift
added a commit
to airspeedswift/swift
that referenced
this pull request
Feb 8, 2018
…shims (swiftlang#14444) * [stdlib] Collection compatibility shim fixes (swiftlang#14342) * Fix compatibility shims for IndexDistance * Add a second test for implied IndexDistance, Bidirectional conformance * Merge pull request swiftlang#14414 from airspeedswift/move-collection-compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of the compatibility shims for the removal of
Collection.IndexDistanceweren't matching the signatures of the methods they were shimming, causing infinite recursion when called (because they were calling themselves). This fixes that and adds tests to confirm they're working.