[5.0][sourcekitd] Fix crash in onDocumentUpdateNotification #14354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathawes
changed the title
|
@swift-ci please test |
nathawes
force-pushed
the
rdar36077481-crash-in-on-document-update-notification-5.0
branch
from
5981586 to
fd462f9
Compare
|
@swift-ci please test |
…g when cancelled from the other end If a client crashes and we tried to post notifications to the XPC connection, SourceKitService would go down too, as it never `xpc_retain`ed the connection. Resolves rdar://problem/36077481
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test and merge |
nathawes
deleted the
rdar36077481-crash-in-on-document-update-notification-5.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceKit didn't
xpc_retaina globally stored XPC connection reference,MainConnection, allowing it to be used in an invalid state. This happened if the client cancelled the connection or crashed while SourceKit was busy gathering semantic information for a document. SourceKit would use the invalid connection to try to notify the client when it finished and crash.Resolves rdar://problem/36077481