Make ImplicitlyUnwrappedOptional<T> an unavailable typealias. #14364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the decl from the known decls and remove a bunch of code referencing that decl as well as a bunch of other random things including deserialization support. This includes removing some specialized diagnostics code that matched the identifier ImplicitlyUnwrappedOptional, and tweaking diagnostics for various modes and various issues. Fixes most of rdar://problem/37121121, among other things.
|
@swift-ci Please smoke test |
|
Ahh, LLDB. |
|
@rudkx The lldb/stable branch is in bad shape at the moment. We also recently enabled gated commits to the stable branch... I'll talk to some folks about changing the lldb bot configuration. If we run the same subset of lldb tests run during smoke testing, you should be able to merge your lldb change. |
|
(See rdar://37034568 for context on why the stable branch is in bad health -- we're working on it.) |
|
@swift-ci Please smoke test |
adrian-prantl
pushed a commit
to apple/swift-lldb
that referenced
this pull request
Feb 10, 2018
As of swiftlang/swift#14299, we should effectively no longer see this decl since we no longer generate IUO types. A follow-on PR actually removes this API completely: swiftlang/swift#14364
adrian-prantl
pushed a commit
to apple/swift-lldb
that referenced
this pull request
Feb 10, 2018
As of swiftlang/swift#14299, we should effectively no longer see this decl since we no longer generate IUO types. A follow-on PR actually removes this API completely: swiftlang/swift#14364 (cherry picked from commit 9fac2e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the decl from the known decls and remove a
bunch of code referencing that decl as well as a bunch of other
random things including deserialization support.
This includes removing some specialized diagnostics code that
matched the identifier ImplicitlyUnwrappedOptional, and tweaking
diagnostics for various modes and various issues.
Fixes most of rdar://problem/37121121, among other things.