Windows runtime initializer #14378
Merged
Windows runtime initializer #14378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, we create synthetic markers with grouping identifiers to ensure that the markers are sorted properly and merged. We would previously mark the section as read/write rather than read-only causing warnings when linking. Correct the attributes. This ensures the proper linking of the modules.
The Windows constructor was not populated properly, with the protocol list being dropped. Ensure that all the fields are initialised properly. Thanks to clang's `-Wmissing-field-initializers` warning to help catch this.
The default attribute on the section is read/write. This would cause the section to have different attributes when compiled. The linker would then preserve the section rather than merge it into the right location. This was noticed when linking with `link.exe`.
|
CC: @troughton |
|
@swift-ci please test and merge |
|
Great, thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.