Add CanType::getOptionalObjectType for staging a rename. #14387
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to replace uses of getAnyOptionalObjectType() with getOptionalObjectType(), we need to update LLDB. But in order to do that, we need to have the version of this function for CanType available. So this adds this, as a temporary measure, to facilitate the LLDB update that will unblock the compiler rename.
|
@swift-ci Please smoke test and merge |
|
@shahmishal I have been seeing multiple timeouts per day on Linux test runs. Do we know what's going on here or have a bug to investigate yet? |
|
@swift-ci Please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to replace uses of getAnyOptionalObjectType() with
getOptionalObjectType(), we need to update LLDB. But in order
to do that, we need to have the version of this function for
CanType available.
So this adds this, as a temporary measure, to facilitate the LLDB
update that will unblock the compiler rename.