[4.1] DefiniteInitialization: Storing back to the 'self' box in a class init is OK. #14395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is OK. SILGen does this now to maintain ownership balance when a class initializer delegation gets interrupted, such as by an error propagation through one of the arguments to the delegatee. Fixes rdar://problem/37007554 .
|
@swift-ci Please test |
|
@gottesmm Does this look ok for 4.1? |
|
SIL test case? |
|
DI is so tightly coupled to SILGen output that I think SIL test cases are useless for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a regression where spurious "self used before super.init" errors would occur when an argument to a
self.initorsuper.initdelegation threw.Scope: Regression from 4.0
Issue: rdar://problem/37007554
Risk: Low, small bug fix
Testing: Swift CI, test case from Radar