[Reflection] Add support for imported structs with recorded fields (attempt #2) #14399
Conversation
|
@swift-ci please test source compatibility |
|
FYI, I just merged a change to XFAIL GRDB and ObjectMapper as these were failing due to earlier changes: swiftlang/swift-source-compat-suite#127 |
|
@xedin Can you add reduced test cases for the two failures that showed up in the source compatibility suite from the earlier attempt at landing this? https://forums.swift.org/t/source-compatibility-bots-in-bad-shape/9526 |
|
Absolutely! I am just trying to re-run and figure out what is going on... |
|
@rudkx this run only got GRDB and ObjectMapper, but I haven’t changed anything in my commit... |
|
@swift-ci please test source compatibility |
|
@rudkx I don’t know what is going on by it looks like compat suite passed with my commit and no changes... |
|
@xedin Interesting. It's a bit of a coincidence those failures were related to metadata and some illegal IR. I suppose we can land again and see what happens... |
|
Let me try to re-run couple more times, and see if this is going to make any difference... |
|
@swift-ci please test source compatibility |
3 similar comments
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility |
|
Last time and if everything is fine I'm going to merge this back in. |
|
Looks like it’s green again, going to merge |
|
@swift-ci please smoke test and merge |
xedin
force-pushed
the
field-desc-for-imported-structs-2.0
branch
from
0ff9338 to
d262dbe
Compare
|
@swift-ci please test source compatibility |
xedin
force-pushed
the
field-desc-for-imported-structs-2.0
branch
from
d262dbe to
e2474ea
Compare
Update IRGen to trigger generation of type metadata for foreign struct types found in fields. And fix TypeRefBuilder to handle the case where struct has fields but at the same time has opaque metadata.
xedin
force-pushed
the
field-desc-for-imported-structs-2.0
branch
from
e2474ea to
8f05d64
Compare
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
SGTM! |
Update IRGen to trigger generation of type metadata for foreign
struct types found in fields. And fix TypeRefBuilder to handle
the case where struct has fields but at the same time has opaque
metadata.