Skip to content

[WIP] [stdlib] Consolidate integer-to-string implementations #14401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2018
Merged

[WIP] [stdlib] Consolidate integer-to-string implementations #14401

merged 1 commit into from
Feb 7, 2018

Conversation

xwu
Copy link
Collaborator

@xwu xwu commented Feb 4, 2018 •
edited
Loading

There's a lot of code to convert integers to strings. Let's consolidate, make it appropriate for all BinaryInteger types, and simplify the web of internal methods.

@xwu
Copy link
Collaborator Author

xwu commented Feb 4, 2018

@swift-ci Please smoke test

@xwu
Copy link
Collaborator Author

xwu commented Feb 4, 2018

@swift-ci Please smoke benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Feb 4, 2018

Build comment file:

Optimized (O)

Regression (3)
TEST OLD NEW DELTA SPEEDUP
StringBuilderLong 1099 1359 +23.7% 0.81x (?)
PopFrontUnsafePointer 8793 9454 +7.5% 0.93x (?)
ObjectiveCBridgeFromNSDictionaryAnyObject 118337 124794 +5.5% 0.95x (?)
Improvement (11)
TEST OLD NEW DELTA SPEEDUP
MapReduceSequence 600 462 -23.0% 1.30x
ArrayAppendReserved 1036 798 -23.0% 1.30x
ArrayPlusEqualFiveElementCollection 7130 5598 -21.5% 1.27x
ArrayPlusEqualSingleElementCollection 1239 1068 -13.8% 1.16x
ArrayAppend 1234 1066 -13.6% 1.16x
MapReduce 455 399 -12.3% 1.14x
DropLastCountableRangeLazy 12 11 -8.3% 1.09x
WordCountUniqueUTF16 24460 22573 -7.7% 1.08x (?)
StringComparison_nonBMPSlowestPrenormal 4972 4676 -6.0% 1.06x
ObjectiveCBridgeFromNSSetAnyObjectToString 71474 67288 -5.9% 1.06x (?)
PrefixWhileSequence 376 356 -5.3% 1.06x
No Changes (346)
TEST OLD NEW DELTA SPEEDUP
AngryPhonebook 3645 3632 -0.4% 1.00x (?)
AnyHashableWithAClass 69981 69651 -0.5% 1.00x (?)
Array2D 2606 2560 -1.8% 1.02x
ArrayAppendArrayOfInt 797 797 +0.0% 1.00x
ArrayAppendAscii 13688 13701 +0.1% 1.00x (?)
ArrayAppendFromGeneric 800 798 -0.2% 1.00x (?)
ArrayAppendGenericStructs 1431 1432 +0.1% 1.00x (?)
ArrayAppendLatin1 38537 39006 +1.2% 0.99x
ArrayAppendLazyMap 1341 1334 -0.5% 1.01x (?)
ArrayAppendOptionals 1431 1428 -0.2% 1.00x (?)
ArrayAppendRepeatCol 1337 1338 +0.1% 1.00x (?)
ArrayAppendSequence 1127 1134 +0.6% 0.99x (?)
ArrayAppendStrings 15176 15176 +0.0% 1.00x
ArrayAppendToFromGeneric 798 798 +0.0% 1.00x
ArrayAppendToGeneric 798 799 +0.1% 1.00x (?)
ArrayAppendUTF16 37932 38385 +1.2% 0.99x
ArrayInClass 85 85 +0.0% 1.00x
ArrayLiteral 0 0 +0.0% 1.00x
ArrayOfGenericPOD2 150 151 +0.7% 0.99x
ArrayOfGenericRef 4372 4367 -0.1% 1.00x (?)
ArrayOfPOD 183 185 +1.1% 0.99x (?)
ArrayOfRef 4401 4371 -0.7% 1.01x (?)
ArrayPlusEqualArrayOfInt 800 799 -0.1% 1.00x (?)
ArrayPlusEqualThreeElements 1671 1655 -1.0% 1.01x
ArraySubscript 1542 1525 -1.1% 1.01x (?)
ArrayValueProp 8 8 +0.0% 1.00x
ArrayValueProp2 8 8 +0.0% 1.00x
ArrayValueProp3 8 8 +0.0% 1.00x
ArrayValueProp4 8 8 +0.0% 1.00x
BinaryFloatingPointConversionFromBinaryInteger 46 46 +0.0% 1.00x
BitCount 211 211 +0.0% 1.00x
ByteSwap 98 98 +0.0% 1.00x
COWTree 3614 3629 +0.4% 1.00x (?)
CSVParsing 758212 759111 +0.1% 1.00x (?)
CSVParsingAlt 728909 728236 -0.1% 1.00x (?)
CSVParsingAltIndices 360840 358000 -0.8% 1.01x (?)
CStringLongAscii 4776 4771 -0.1% 1.00x
CStringLongNonAscii 2171 2112 -2.7% 1.03x
CStringShortAscii 4705 4706 +0.0% 1.00x (?)
Calculator 432 442 +2.3% 0.98x
CaptureProp 9169 8895 -3.0% 1.03x
CharIndexing_ascii_unicodeScalars 15341 15334 -0.0% 1.00x (?)
CharIndexing_ascii_unicodeScalars_Backwards 14976 14975 -0.0% 1.00x (?)
CharIndexing_chinese_unicodeScalars 11622 11623 +0.0% 1.00x (?)
CharIndexing_chinese_unicodeScalars_Backwards 11351 11346 -0.0% 1.00x (?)
CharIndexing_japanese_unicodeScalars 18372 18364 -0.0% 1.00x (?)
CharIndexing_japanese_unicodeScalars_Backwards 17931 17926 -0.0% 1.00x (?)
CharIndexing_korean_unicodeScalars 14893 14886 -0.0% 1.00x (?)
CharIndexing_korean_unicodeScalars_Backwards 14524 14532 +0.1% 1.00x (?)
CharIndexing_punctuatedJapanese_unicodeScalars 2791 2791 +0.0% 1.00x
CharIndexing_punctuatedJapanese_unicodeScalars_Backwards 2729 2729 +0.0% 1.00x
CharIndexing_punctuated_unicodeScalars 3491 3489 -0.1% 1.00x (?)
CharIndexing_punctuated_unicodeScalars_Backwards 3413 3424 +0.3% 1.00x (?)
CharIndexing_russian_unicodeScalars 12806 12786 -0.2% 1.00x (?)
CharIndexing_russian_unicodeScalars_Backwards 12485 12487 +0.0% 1.00x (?)
CharIndexing_tweet_unicodeScalars 30265 30270 +0.0% 1.00x (?)
CharIndexing_tweet_unicodeScalars_Backwards 29481 29535 +0.2% 1.00x
CharIndexing_utf16_unicodeScalars 20762 20648 -0.5% 1.01x
CharIndexing_utf16_unicodeScalars_Backwards 21574 21521 -0.2% 1.00x
CharIteration_ascii_unicodeScalars 21193 21049 -0.7% 1.01x
CharIteration_ascii_unicodeScalars_Backwards 13508 13510 +0.0% 1.00x (?)
CharIteration_chinese_unicodeScalars 16052 15905 -0.9% 1.01x
CharIteration_chinese_unicodeScalars_Backwards 10263 10257 -0.1% 1.00x
CharIteration_japanese_unicodeScalars 25428 25212 -0.8% 1.01x
CharIteration_japanese_unicodeScalars_Backwards 16143 16150 +0.0% 1.00x (?)
CharIteration_korean_unicodeScalars 20565 20417 -0.7% 1.01x
CharIteration_korean_unicodeScalars_Backwards 13120 13118 -0.0% 1.00x (?)
CharIteration_punctuatedJapanese_unicodeScalars 3778 3757 -0.6% 1.01x
CharIteration_punctuatedJapanese_unicodeScalars_Backwards 2498 2497 -0.0% 1.00x (?)
CharIteration_punctuated_unicodeScalars 4749 4719 -0.6% 1.01x
CharIteration_punctuated_unicodeScalars_Backwards 3111 3110 -0.0% 1.00x (?)
CharIteration_russian_unicodeScalars 17673 17539 -0.8% 1.01x
CharIteration_russian_unicodeScalars_Backwards 11290 11307 +0.2% 1.00x (?)
CharIteration_tweet_unicodeScalars 41852 41570 -0.7% 1.01x
CharIteration_tweet_unicodeScalars_Backwards 26598 26615 +0.1% 1.00x (?)
CharIteration_utf16_unicodeScalars 27729 27610 -0.4% 1.00x
CharIteration_utf16_unicodeScalars_Backwards 16991 17041 +0.3% 1.00x
CharacterLiteralsLarge 6198 6101 -1.6% 1.02x
CharacterLiteralsSmall 424 411 -3.1% 1.03x
CharacterPropertiesFetch 4736 4573 -3.4% 1.04x
CharacterPropertiesPrecomputed 977 969 -0.8% 1.01x (?)
CharacterPropertiesStashed 1573 1579 +0.4% 1.00x (?)
CharacterPropertiesStashedMemo 1560 1547 -0.8% 1.01x (?)
Chars 965 970 +0.5% 0.99x
ClassArrayGetter 15 15 +0.0% 1.00x
Combos 452 453 +0.2% 1.00x (?)
DictOfArraysToArrayOfDicts 787 783 -0.5% 1.01x (?)
Dictionary 501 503 +0.4% 1.00x (?)
Dictionary2 1609 1605 -0.2% 1.00x (?)
Dictionary2OfObjects 2968 2966 -0.1% 1.00x (?)
Dictionary3 236 233 -1.3% 1.01x
Dictionary3OfObjects 673 672 -0.1% 1.00x (?)
DictionaryBridge 2026 2027 +0.0% 1.00x (?)
DictionaryGroup 134 133 -0.7% 1.01x
DictionaryGroupOfObjects 1921 1916 -0.3% 1.00x (?)
DictionaryLiteral 1624 1648 +1.5% 0.99x
DictionaryOfObjects 2174 2172 -0.1% 1.00x (?)
DictionaryRemove 2863 2955 +3.2% 0.97x (?)
DictionaryRemoveOfObjects 23730 23729 -0.0% 1.00x (?)
DictionarySubscriptDefaultMutation 150 150 +0.0% 1.00x
DictionarySubscriptDefaultMutationArray 494 493 -0.2% 1.00x
DictionarySubscriptDefaultMutationArrayOfObjects 3831 3838 +0.2% 1.00x (?)
DictionarySubscriptDefaultMutationOfObjects 1385 1380 -0.4% 1.00x (?)
DictionarySwap 488 487 -0.2% 1.00x
DictionarySwapOfObjects 7461 7307 -2.1% 1.02x (?)
DoubleWidthDivision 244 240 -1.6% 1.02x
DropFirstAnyCollection 76 76 +0.0% 1.00x
DropFirstAnyCollectionLazy 66007 65304 -1.1% 1.01x (?)
DropFirstAnySeqCRangeIter 18305 18511 +1.1% 0.99x
DropFirstAnySeqCRangeIterLazy 18301 18531 +1.3% 0.99x
DropFirstAnySeqCntRange 71 71 +0.0% 1.00x
DropFirstAnySeqCntRangeLazy 71 71 +0.0% 1.00x
DropFirstAnySequence 4673 4513 -3.4% 1.04x
DropFirstAnySequenceLazy 4484 4548 +1.4% 0.99x
DropFirstArray 35 35 +0.0% 1.00x
DropFirstArrayLazy 35 35 +0.0% 1.00x
DropFirstCountableRange 35 35 +0.0% 1.00x
DropFirstCountableRangeLazy 35 35 +0.0% 1.00x
DropFirstSequence 2697 2697 +0.0% 1.00x
DropFirstSequenceLazy 2794 2794 +0.0% 1.00x
DropLastAnyCollection 28 28 +0.0% 1.00x
DropLastAnyCollectionLazy 21858 21995 +0.6% 0.99x (?)
DropLastAnySeqCRangeIter 3560 3538 -0.6% 1.01x
DropLastAnySeqCRangeIterLazy 3561 3537 -0.7% 1.01x
DropLastAnySeqCntRange 23 23 +0.0% 1.00x
DropLastAnySeqCntRangeLazy 23 23 +0.0% 1.00x
DropLastAnySequence 5123 5129 +0.1% 1.00x (?)
DropLastAnySequenceLazy 5244 5228 -0.3% 1.00x (?)
DropLastCountableRange 11 11 +0.0% 1.00x
DropLastSequence 684 683 -0.1% 1.00x
DropLastSequenceLazy 682 681 -0.1% 1.00x
DropWhileAnyCollection 100 100 +0.0% 1.00x
DropWhileAnyCollectionLazy 147 147 +0.0% 1.00x
DropWhileAnySeqCRangeIter 14914 15005 +0.6% 0.99x (?)
DropWhileAnySeqCRangeIterLazy 148 147 -0.7% 1.01x
DropWhileAnySeqCntRange 95 95 +0.0% 1.00x
DropWhileAnySeqCntRangeLazy 147 147 +0.0% 1.00x
DropWhileAnySequence 4858 4755 -2.1% 1.02x
DropWhileAnySequenceLazy 1857 1856 -0.1% 1.00x
DropWhileArrayLazy 129 129 +0.0% 1.00x
DropWhileCountableRange 36 36 +0.0% 1.00x
DropWhileCountableRangeLazy 111 111 +0.0% 1.00x
DropWhileSequence 1341 1341 +0.0% 1.00x
DropWhileSequenceLazy 88 88 +0.0% 1.00x
EqualStringSubstring 432 433 +0.2% 1.00x (?)
EqualSubstringString 432 432 +0.0% 1.00x
EqualSubstringSubstring 430 432 +0.5% 1.00x (?)
EqualSubstringSubstringGenericEquatable 432 431 -0.2% 1.00x (?)
ErrorHandling 2345 2362 +0.7% 0.99x (?)
ExclusivityGlobal 5 5 +0.0% 1.00x
ExclusivityIndependent 2 2 +0.0% 1.00x
FilterEvenUsingReduce 1322 1323 +0.1% 1.00x (?)
FilterEvenUsingReduceInto 149 149 +0.0% 1.00x
FrequenciesUsingReduce 6727 6963 +3.5% 0.97x
FrequenciesUsingReduceInto 3206 3202 -0.1% 1.00x (?)
Hanoi 3645 3635 -0.3% 1.00x (?)
HashTest 1781 1768 -0.7% 1.01x
Histogram 333 333 +0.0% 1.00x
Integrate 217 217 +0.0% 1.00x
IterateData 1379 1382 +0.2% 1.00x (?)
Join 371 370 -0.3% 1.00x
LazilyFilteredArrayContains 36685 36672 -0.0% 1.00x (?)
LazilyFilteredArrays 67148 65178 -2.9% 1.03x (?)
LazilyFilteredRange 3829 3830 +0.0% 1.00x (?)
LessSubstringSubstring 431 432 +0.2% 1.00x (?)
LessSubstringSubstringGenericComparable 434 436 +0.5% 1.00x (?)
LinkedList 7548 7543 -0.1% 1.00x (?)
LuhnAlgoEager 588 587 -0.2% 1.00x (?)
LuhnAlgoLazy 592 587 -0.8% 1.01x
MapReduceAnyCollection 399 400 +0.3% 1.00x (?)
MapReduceAnyCollectionShort 2081 2102 +1.0% 0.99x (?)
MapReduceClass 3040 3039 -0.0% 1.00x (?)
MapReduceClassShort 4691 4608 -1.8% 1.02x
MapReduceLazyCollection 13 13 +0.0% 1.00x
MapReduceLazyCollectionShort 38 38 +0.0% 1.00x
MapReduceLazySequence 86 86 +0.0% 1.00x
MapReduceShort 2040 2053 +0.6% 0.99x (?)
MapReduceShortString 22 21 -4.5% 1.05x
MapReduceString 81 81 +0.0% 1.00x
Memset 215 219 +1.9% 0.98x (?)
MonteCarloE 10498 10488 -0.1% 1.00x (?)
MonteCarloPi 42922 42942 +0.0% 1.00x (?)
NSDictionaryCastToSwift 5422 5387 -0.6% 1.01x (?)
NSError 306 303 -1.0% 1.01x (?)
NSStringConversion 320 320 +0.0% 1.00x
NibbleSort 4127 4127 +0.0% 1.00x
NopDeinit 23784 23425 -1.5% 1.02x
ObjectAllocation 183 183 +0.0% 1.00x
ObjectiveCBridgeFromNSArrayAnyObject 20153 20472 +1.6% 0.98x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 3931 3891 -1.0% 1.01x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 37162 38298 +3.1% 0.97x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 34109 34368 +0.8% 0.99x (?)
ObjectiveCBridgeFromNSSetAnyObject 58654 61259 +4.4% 0.96x (?)
ObjectiveCBridgeFromNSSetAnyObjectForced 4252 4400 +3.5% 0.97x
ObjectiveCBridgeFromNSString 1372 1335 -2.7% 1.03x
ObjectiveCBridgeFromNSStringForced 2338 2353 +0.6% 0.99x (?)
ObjectiveCBridgeStubDataAppend 4085 4033 -1.3% 1.01x (?)
ObjectiveCBridgeStubDateMutation 257 257 +0.0% 1.00x
ObjectiveCBridgeStubFromArrayOfNSString 26133 26262 +0.5% 1.00x (?)
ObjectiveCBridgeStubFromNSDate 4261 4249 -0.3% 1.00x (?)
ObjectiveCBridgeStubFromNSString 842 852 +1.2% 0.99x
ObjectiveCBridgeStubFromNSStringRef 159 159 +0.0% 1.00x
ObjectiveCBridgeStubNSDataAppend 2629 2526 -3.9% 1.04x (?)
ObjectiveCBridgeStubNSDateMutationRef 13518 13348 -1.3% 1.01x (?)
ObjectiveCBridgeStubToArrayOfNSString 29190 28638 -1.9% 1.02x (?)
ObjectiveCBridgeStubToNSDate 15413 16087 +4.4% 0.96x (?)
ObjectiveCBridgeStubToNSDateRef 3482 3499 +0.5% 1.00x (?)
ObjectiveCBridgeStubToNSString 1552 1546 -0.4% 1.00x (?)
ObjectiveCBridgeStubToNSStringRef 116 115 -0.9% 1.01x
ObjectiveCBridgeStubURLAppendPath 335602 328536 -2.1% 1.02x (?)
ObjectiveCBridgeStubURLAppendPathRef 343835 337998 -1.7% 1.02x (?)
ObjectiveCBridgeToNSArray 29388 30140 +2.6% 0.98x
ObjectiveCBridgeToNSDictionary 54032 53571 -0.9% 1.01x (?)
ObjectiveCBridgeToNSSet 46420 46316 -0.2% 1.00x (?)
ObjectiveCBridgeToNSString 1314 1316 +0.2% 1.00x
ObserverClosure 2151 2164 +0.6% 0.99x
ObserverForwarderStruct 994 1000 +0.6% 0.99x (?)
ObserverPartiallyAppliedMethod 3735 3747 +0.3% 1.00x (?)
ObserverUnappliedMethod 2381 2397 +0.7% 0.99x
OpenClose 263 263 +0.0% 1.00x
PartialApplyDynamicType 0 0 +0.0% 1.00x
Phonebook 4115 4115 +0.0% 1.00x
PointerArithmetics 31503 31523 +0.1% 1.00x (?)
PolymorphicCalls 25 25 +0.0% 1.00x
PopFrontArray 1940 1865 -3.9% 1.04x (?)
PopFrontArrayGeneric 1962 1960 -0.1% 1.00x (?)
PrefixAnyCollection 76 76 +0.0% 1.00x
PrefixAnyCollectionLazy 67427 65244 -3.2% 1.03x
PrefixAnySeqCRangeIter 14195 14125 -0.5% 1.00x (?)
PrefixAnySeqCRangeIterLazy 14211 14182 -0.2% 1.00x (?)
PrefixAnySeqCntRange 71 71 +0.0% 1.00x
PrefixAnySeqCntRangeLazy 71 71 +0.0% 1.00x
PrefixAnySequence 3833 3831 -0.1% 1.00x (?)
PrefixAnySequenceLazy 3852 3858 +0.2% 1.00x (?)
PrefixArray 35 35 +0.0% 1.00x
PrefixArrayLazy 35 35 +0.0% 1.00x
PrefixCountableRange 35 35 +0.0% 1.00x
PrefixCountableRangeLazy 35 35 +0.0% 1.00x
PrefixSequence 1326 1326 +0.0% 1.00x
PrefixSequenceLazy 1414 1414 +0.0% 1.00x
PrefixWhileAnyCollection 146 146 +0.0% 1.00x
PrefixWhileAnyCollectionLazy 106 106 +0.0% 1.00x
PrefixWhileAnySeqCRangeIter 9335 9400 +0.7% 0.99x (?)
PrefixWhileAnySeqCRangeIterLazy 106 106 +0.0% 1.00x
PrefixWhileAnySeqCntRange 142 142 +0.0% 1.00x
PrefixWhileAnySeqCntRangeLazy 106 106 +0.0% 1.00x
PrefixWhileAnySequence 10645 10478 -1.6% 1.02x
PrefixWhileAnySequenceLazy 1392 1392 +0.0% 1.00x
PrefixWhileArray 88 88 +0.0% 1.00x
PrefixWhileArrayLazy 70 70 +0.0% 1.00x
PrefixWhileCountableRange 53 53 +0.0% 1.00x
PrefixWhileCountableRangeLazy 35 35 +0.0% 1.00x
PrefixWhileSequenceLazy 52 52 +0.0% 1.00x
Prims 752 752 +0.0% 1.00x
PrimsSplit 756 755 -0.1% 1.00x (?)
QueueConcrete 1312 1309 -0.2% 1.00x
QueueGeneric 1158 1158 +0.0% 1.00x
RC4 165 165 +0.0% 1.00x
RGBHistogram 2953 2954 +0.0% 1.00x (?)
RGBHistogramOfObjects 23889 23836 -0.2% 1.00x
RangeAssignment 354 354 +0.0% 1.00x
RangeIterationSigned 200 200 +0.0% 1.00x
RangeIterationSigned64 200 200 +0.0% 1.00x
RangeIterationUnsigned 200 200 +0.0% 1.00x
RangeReplaceableCollectionPlusDefault 977 982 +0.5% 0.99x (?)
RecursiveOwnedParameter 2325 2323 -0.1% 1.00x
ReversedArray 57 57 +0.0% 1.00x
ReversedBidirectional 15440 15343 -0.6% 1.01x
ReversedDictionary 127 129 +1.6% 0.98x (?)
RomanNumbers 114740 114634 -0.1% 1.00x (?)
SetExclusiveOr 3619 3591 -0.8% 1.01x (?)
SetExclusiveOr_OfObjects 8705 8666 -0.4% 1.00x (?)
SetIntersect 319 319 +0.0% 1.00x
SetIntersect_OfObjects 1781 1779 -0.1% 1.00x (?)
SetIsSubsetOf 300 300 +0.0% 1.00x
SetIsSubsetOf_OfObjects 363 364 +0.3% 1.00x (?)
SetUnion 3264 3226 -1.2% 1.01x (?)
SetUnion_OfObjects 7170 7205 +0.5% 1.00x (?)
SevenBoom 1543 1533 -0.6% 1.01x (?)
Sim2DArray 670 670 +0.0% 1.00x
SortLargeExistentials 7163 7157 -0.1% 1.00x (?)
SortLettersInPlace 1161 1159 -0.2% 1.00x (?)
SortSortedStrings 1159 1158 -0.1% 1.00x (?)
SortStrings 2040 2039 -0.0% 1.00x (?)
SortStringsUnicode 15453 15427 -0.2% 1.00x
StackPromo 22421 22151 -1.2% 1.01x
StaticArray 6 6 +0.0% 1.00x
StrComplexWalk 1566 1566 +0.0% 1.00x
StrToInt 2182 2174 -0.4% 1.00x (?)
StringAdder 4252 4239 -0.3% 1.00x (?)
StringBuilder 1449 1439 -0.7% 1.01x
StringComparison_abnormal 861 862 +0.1% 1.00x
StringComparison_ascii 977 977 +0.0% 1.00x
StringComparison_emoji 2562 2555 -0.3% 1.00x
StringComparison_fastPrenormal 8738 8714 -0.3% 1.00x
StringComparison_latin1 6039 6029 -0.2% 1.00x (?)
StringComparison_longSharedPrefix 11519 11516 -0.0% 1.00x (?)
StringComparison_slowerPrenormal 4177 4166 -0.3% 1.00x
StringComparison_zalgo 1729 1735 +0.3% 1.00x (?)
StringEdits 117005 118031 +0.9% 0.99x (?)
StringEnumRawValueInitialization 1005 981 -2.4% 1.02x
StringEqualPointerComparison 286 286 +0.0% 1.00x
StringFromLongWholeSubstring 21 21 +0.0% 1.00x
StringFromLongWholeSubstringGeneric 10 10 +0.0% 1.00x
StringHasPrefixAscii 1575 1575 +0.0% 1.00x
StringHasPrefixUnicode 28003 28154 +0.5% 0.99x
StringHasSuffixAscii 1719 1718 -0.1% 1.00x
StringHasSuffixUnicode 85506 85350 -0.2% 1.00x (?)
StringInterpolation 9445 9465 +0.2% 1.00x (?)
StringMatch 7583 7592 +0.1% 1.00x (?)
StringRemoveDupes 1212 1202 -0.8% 1.01x (?)
StringUTF16Builder 2447 2425 -0.9% 1.01x
StringWalk 1523 1521 -0.1% 1.00x (?)
StringWithCString 43597 43230 -0.8% 1.01x
StringWordBuilder 1739 1738 -0.1% 1.00x (?)
StringWordBuilderReservingCapacity 1299 1300 +0.1% 1.00x (?)
SubstringComparable 2118 2123 +0.2% 1.00x (?)
SubstringEqualString 2121 2101 -0.9% 1.01x
SubstringEquatable 3175 3187 +0.4% 1.00x (?)
SubstringFromLongString 10 10 +0.0% 1.00x
SubstringFromLongStringGeneric 84 87 +3.6% 0.97x (?)
SuffixAnyCollection 28 28 +0.0% 1.00x
SuffixAnyCollectionLazy 22396 21802 -2.7% 1.03x (?)
SuffixAnySeqCRangeIter 3814 3838 +0.6% 0.99x (?)
SuffixAnySeqCRangeIterLazy 3850 3838 -0.3% 1.00x
SuffixAnySeqCntRange 23 23 +0.0% 1.00x
SuffixAnySeqCntRangeLazy 23 23 +0.0% 1.00x
SuffixAnySequence 5094 5123 +0.6% 0.99x
SuffixAnySequenceLazy 5224 5233 +0.2% 1.00x
SuffixCountableRange 11 11 +0.0% 1.00x
SuffixCountableRangeLazy 12 12 +0.0% 1.00x
SuffixSequence 3755 3749 -0.2% 1.00x (?)
SuffixSequenceLazy 3747 3743 -0.1% 1.00x (?)
SumUsingReduce 97 97 +0.0% 1.00x
SumUsingReduceInto 97 97 +0.0% 1.00x
SuperChars 41461 42412 +2.3% 0.98x (?)
TwoSum 1010 993 -1.7% 1.02x (?)
TypeFlood 0 0 +0.0% 1.00x
UTF8Decode 313 313 +0.0% 1.00x
Walsh 413 413 +0.0% 1.00x
WordCountHistogramASCII 8185 8149 -0.4% 1.00x
WordCountHistogramUTF16 56420 55464 -1.7% 1.02x (?)
WordCountUniqueASCII 1815 1791 -1.3% 1.01x
WordSplitASCII 21027 21008 -0.1% 1.00x (?)
WordSplitUTF16 22310 21888 -1.9% 1.02x
XorLoop 392 394 +0.5% 0.99x (?)

Unoptimized (Onone)

Regression (14)
TEST OLD NEW DELTA SPEEDUP
SuperChars 218484 254352 +16.4% 0.86x (?)
SuffixAnyCollectionLazy 34294 38149 +11.2% 0.90x
ArrayAppendUTF16 62692 68683 +9.6% 0.91x
DropLastAnyCollectionLazy 34995 38317 +9.5% 0.91x
WordSplitUTF16 27120 29659 +9.4% 0.91x
PrefixAnyCollectionLazy 105201 114723 +9.1% 0.92x
NSDictionaryCastToSwift 6596 7132 +8.1% 0.92x (?)
ObjectiveCBridgeFromNSSetAnyObject 61819 66353 +7.3% 0.93x (?)
CharacterPropertiesStashedMemo 4928 5277 +7.1% 0.93x (?)
CharacterPropertiesPrecomputed 4466 4776 +6.9% 0.94x
StringHasSuffixUnicode 88390 93618 +5.9% 0.94x
StringWithCString 37580 39745 +5.8% 0.95x
FrequenciesUsingReduce 10486 11062 +5.5% 0.95x (?)
ObjectiveCBridgeFromNSArrayAnyObject 22128 23319 +5.4% 0.95x (?)
Improvement (36)
TEST OLD NEW DELTA SPEEDUP
CharIndexing_japanese_unicodeScalars_Backwards 587700 457644 -22.1% 1.28x
CharIteration_punctuated_unicodeScalars 44011 34628 -21.3% 1.27x
CharIndexing_ascii_unicodeScalars_Backwards 494454 389709 -21.2% 1.27x
CharIndexing_punctuated_unicodeScalars_Backwards 108137 85637 -20.8% 1.26x
CharIndexing_chinese_unicodeScalars 332939 265980 -20.1% 1.25x
CharIndexing_punctuatedJapanese_unicodeScalars_Backwards 82740 66669 -19.4% 1.24x
CharIndexing_korean_unicodeScalars_Backwards 478494 385990 -19.3% 1.24x
CharIndexing_chinese_unicodeScalars_Backwards 369493 303402 -17.9% 1.22x
CharIndexing_tweet_unicodeScalars_Backwards 925479 761475 -17.7% 1.22x
CharIndexing_tweet_unicodeScalars 852090 702039 -17.6% 1.21x
CharIndexing_russian_unicodeScalars 353856 293169 -17.2% 1.21x
CharIndexing_korean_unicodeScalars 410671 340996 -17.0% 1.20x
CharIndexing_japanese_unicodeScalars 507831 421833 -16.9% 1.20x
SevenBoom 2006 1667 -16.9% 1.20x (?)
CharIndexing_punctuatedJapanese_unicodeScalars 77541 64609 -16.7% 1.20x
CharIndexing_ascii_unicodeScalars 419785 351918 -16.2% 1.19x
CharIndexing_punctuated_unicodeScalars 93321 78659 -15.7% 1.19x
CharIndexing_utf16_unicodeScalars_Backwards 381889 323759 -15.2% 1.18x
CharIteration_korean_unicodeScalars_Backwards 331531 284526 -14.2% 1.17x
CharIteration_ascii_unicodeScalars_Backwards 340790 293038 -14.0% 1.16x
CharIndexing_russian_unicodeScalars_Backwards 406707 352111 -13.4% 1.16x
CharIndexing_utf16_unicodeScalars 346483 300018 -13.4% 1.15x
RangeReplaceableCollectionPlusDefault 8987 8006 -10.9% 1.12x
ArrayOfPOD 842 755 -10.3% 1.12x
ObjectiveCBridgeFromNSSetAnyObjectToString 81861 74002 -9.6% 1.11x (?)
TypeFlood 162 147 -9.3% 1.10x (?)
ReversedBidirectional 46869 42688 -8.9% 1.10x (?)
ObjectiveCBridgeFromNSSetAnyObjectForced 7513 6941 -7.6% 1.08x (?)
StrToInt 61286 57028 -6.9% 1.07x
MapReduceShortString 262 245 -6.5% 1.07x
ObjectiveCBridgeStubToNSDate 16068 15074 -6.2% 1.07x (?)
ObjectiveCBridgeFromNSString 3303 3106 -6.0% 1.06x (?)
NSError 753 711 -5.6% 1.06x
StringComparison_latin1 10077 9542 -5.3% 1.06x
StringInterpolation 14121 13402 -5.1% 1.05x
RangeAssignment 2859 2719 -4.9% 1.05x
No Changes (310)
TEST OLD NEW DELTA SPEEDUP
AngryPhonebook 5069 5124 +1.1% 0.99x (?)
AnyHashableWithAClass 86588 86510 -0.1% 1.00x (?)
Array2D 633665 633341 -0.1% 1.00x (?)
ArrayAppend 4665 4667 +0.0% 1.00x (?)
ArrayAppendArrayOfInt 859 863 +0.5% 1.00x (?)
ArrayAppendAscii 40256 40362 +0.3% 1.00x
ArrayAppendFromGeneric 862 864 +0.2% 1.00x (?)
ArrayAppendGenericStructs 1499 1505 +0.4% 1.00x (?)
ArrayAppendLatin1 63405 64123 +1.1% 0.99x
ArrayAppendLazyMap 167638 171155 +2.1% 0.98x (?)
ArrayAppendOptionals 1501 1503 +0.1% 1.00x (?)
ArrayAppendRepeatCol 170443 173360 +1.7% 0.98x
ArrayAppendReserved 4279 4284 +0.1% 1.00x (?)
ArrayAppendSequence 144742 143395 -0.9% 1.01x
ArrayAppendStrings 15443 15461 +0.1% 1.00x
ArrayAppendToFromGeneric 863 866 +0.3% 1.00x
ArrayAppendToGeneric 866 869 +0.3% 1.00x (?)
ArrayInClass 6195 6191 -0.1% 1.00x (?)
ArrayLiteral 1779 1788 +0.5% 0.99x (?)
ArrayOfGenericPOD2 1186 1131 -4.6% 1.05x
ArrayOfGenericRef 10123 10091 -0.3% 1.00x (?)
ArrayOfRef 9414 9288 -1.3% 1.01x (?)
ArrayPlusEqualArrayOfInt 866 866 +0.0% 1.00x
ArrayPlusEqualFiveElementCollection 234552 234339 -0.1% 1.00x (?)
ArrayPlusEqualSingleElementCollection 229537 232745 +1.4% 0.99x (?)
ArrayPlusEqualThreeElements 9195 9288 +1.0% 0.99x (?)
ArraySubscript 81221 80658 -0.7% 1.01x (?)
ArrayValueProp 3620 3619 -0.0% 1.00x (?)
ArrayValueProp2 15990 16040 +0.3% 1.00x (?)
ArrayValueProp3 4099 4122 +0.6% 0.99x (?)
ArrayValueProp4 4071 4086 +0.4% 1.00x (?)
BinaryFloatingPointConversionFromBinaryInteger 5954 5840 -1.9% 1.02x (?)
BitCount 2208 2207 -0.0% 1.00x (?)
ByteSwap 3911 3927 +0.4% 1.00x
COWTree 11262 11368 +0.9% 0.99x (?)
CSVParsing 2446628 2497975 +2.1% 0.98x (?)
CSVParsingAlt 1349180 1333123 -1.2% 1.01x (?)
CSVParsingAltIndices 2543732 2509647 -1.3% 1.01x (?)
CStringLongAscii 4602 4759 +3.4% 0.97x
CStringLongNonAscii 2145 2087 -2.7% 1.03x
CStringShortAscii 7670 7726 +0.7% 0.99x (?)
Calculator 1762 1727 -2.0% 1.02x
CaptureProp 255472 253484 -0.8% 1.01x
CharIteration_ascii_unicodeScalars 152750 153527 +0.5% 0.99x (?)
CharIteration_chinese_unicodeScalars 115531 116256 +0.6% 0.99x (?)
CharIteration_chinese_unicodeScalars_Backwards 220562 221104 +0.2% 1.00x (?)
CharIteration_japanese_unicodeScalars 183085 184028 +0.5% 0.99x
CharIteration_japanese_unicodeScalars_Backwards 349201 348210 -0.3% 1.00x (?)
CharIteration_korean_unicodeScalars 152389 149103 -2.2% 1.02x (?)
CharIteration_punctuatedJapanese_unicodeScalars 27799 27497 -1.1% 1.01x
CharIteration_punctuatedJapanese_unicodeScalars_Backwards 51197 50575 -1.2% 1.01x (?)
CharIteration_punctuated_unicodeScalars_Backwards 67808 64587 -4.8% 1.05x (?)
CharIteration_russian_unicodeScalars 127929 127885 -0.0% 1.00x (?)
CharIteration_russian_unicodeScalars_Backwards 240591 244256 +1.5% 0.98x (?)
CharIteration_tweet_unicodeScalars 301508 303444 +0.6% 0.99x (?)
CharIteration_tweet_unicodeScalars_Backwards 579183 582900 +0.6% 0.99x (?)
CharIteration_utf16_unicodeScalars 130114 129480 -0.5% 1.00x
CharIteration_utf16_unicodeScalars_Backwards 246964 246597 -0.1% 1.00x (?)
CharacterLiteralsLarge 5944 6002 +1.0% 0.99x (?)
CharacterLiteralsSmall 708 708 +0.0% 1.00x
CharacterPropertiesFetch 5395 5479 +1.6% 0.98x (?)
CharacterPropertiesStashed 2367 2380 +0.5% 0.99x (?)
Chars 39989 40079 +0.2% 1.00x (?)
ClassArrayGetter 981 985 +0.4% 1.00x
Combos 2018 2067 +2.4% 0.98x (?)
DictOfArraysToArrayOfDicts 3356 3368 +0.4% 1.00x (?)
Dictionary 2573 2624 +2.0% 0.98x (?)
Dictionary2 2840 2887 +1.7% 0.98x (?)
Dictionary2OfObjects 5689 5624 -1.1% 1.01x (?)
Dictionary3 1274 1274 +0.0% 1.00x
Dictionary3OfObjects 2291 2329 +1.7% 0.98x (?)
DictionaryBridge 2133 2154 +1.0% 0.99x (?)
DictionaryGroup 4248 4229 -0.4% 1.00x
DictionaryGroupOfObjects 7566 7552 -0.2% 1.00x (?)
DictionaryLiteral 8459 8509 +0.6% 0.99x (?)
DictionaryOfObjects 6298 6058 -3.8% 1.04x (?)
DictionaryRemove 18186 18080 -0.6% 1.01x
DictionaryRemoveOfObjects 51309 49691 -3.2% 1.03x (?)
DictionarySubscriptDefaultMutation 2128 2120 -0.4% 1.00x (?)
DictionarySubscriptDefaultMutationArray 2367 2359 -0.3% 1.00x
DictionarySubscriptDefaultMutationArrayOfObjects 9102 9191 +1.0% 0.99x (?)
DictionarySubscriptDefaultMutationOfObjects 5757 5625 -2.3% 1.02x (?)
DictionarySwap 5170 5207 +0.7% 0.99x
DictionarySwapOfObjects 22456 22686 +1.0% 0.99x (?)
DoubleWidthDivision 24060 24056 -0.0% 1.00x (?)
DropFirstAnyCollection 13699 13627 -0.5% 1.01x
DropFirstAnyCollectionLazy 108824 112187 +3.1% 0.97x (?)
DropFirstAnySeqCRangeIter 20417 20707 +1.4% 0.99x
DropFirstAnySeqCRangeIterLazy 20306 20477 +0.8% 0.99x
DropFirstAnySeqCntRange 13694 13607 -0.6% 1.01x
DropFirstAnySeqCntRangeLazy 13741 13658 -0.6% 1.01x
DropFirstAnySequence 10712 10780 +0.6% 0.99x
DropFirstAnySequenceLazy 10705 10740 +0.3% 1.00x (?)
DropFirstArray 3818 3771 -1.2% 1.01x
DropFirstArrayLazy 24941 25094 +0.6% 0.99x (?)
DropFirstCountableRange 324 325 +0.3% 1.00x (?)
DropFirstCountableRangeLazy 25814 27082 +4.9% 0.95x (?)
DropFirstSequence 10422 10411 -0.1% 1.00x (?)
DropFirstSequenceLazy 10406 10375 -0.3% 1.00x
DropLastAnyCollection 4587 4571 -0.3% 1.00x
DropLastAnySeqCRangeIter 37747 37272 -1.3% 1.01x
DropLastAnySeqCRangeIterLazy 37770 37626 -0.4% 1.00x (?)
DropLastAnySeqCntRange 4584 4534 -1.1% 1.01x
DropLastAnySeqCntRangeLazy 4616 4601 -0.3% 1.00x
DropLastAnySequence 28721 28908 +0.7% 0.99x
DropLastAnySequenceLazy 29016 29077 +0.2% 1.00x
DropLastCountableRange 111 111 +0.0% 1.00x
DropLastCountableRangeLazy 8815 9071 +2.9% 0.97x (?)
DropLastSequence 28797 28894 +0.3% 1.00x (?)
DropLastSequenceLazy 28760 28894 +0.5% 1.00x
DropWhileAnyCollection 17455 17372 -0.5% 1.00x
DropWhileAnyCollectionLazy 18872 18895 +0.1% 1.00x
DropWhileAnySeqCRangeIter 21969 22063 +0.4% 1.00x (?)
DropWhileAnySeqCRangeIterLazy 19168 18976 -1.0% 1.01x
DropWhileAnySeqCntRange 17515 17406 -0.6% 1.01x
DropWhileAnySeqCntRangeLazy 18755 18809 +0.3% 1.00x (?)
DropWhileAnySequence 12206 12225 +0.2% 1.00x (?)
DropWhileAnySequenceLazy 9997 9949 -0.5% 1.00x (?)
DropWhileArrayLazy 13625 13657 +0.2% 1.00x
DropWhileCountableRange 4154 4217 +1.5% 0.99x
DropWhileCountableRangeLazy 18403 18753 +1.9% 0.98x
DropWhileSequence 12007 12005 -0.0% 1.00x (?)
DropWhileSequenceLazy 9640 9631 -0.1% 1.00x (?)
EqualStringSubstring 475 476 +0.2% 1.00x (?)
EqualSubstringString 476 477 +0.2% 1.00x (?)
EqualSubstringSubstring 476 478 +0.4% 1.00x (?)
EqualSubstringSubstringGenericEquatable 492 484 -1.6% 1.02x (?)
ErrorHandling 7061 7379 +4.5% 0.96x (?)
ExclusivityGlobal 180 179 -0.6% 1.01x (?)
ExclusivityIndependent 68 68 +0.0% 1.00x
FilterEvenUsingReduce 3810 3830 +0.5% 0.99x (?)
FilterEvenUsingReduceInto 1978 1991 +0.7% 0.99x
FrequenciesUsingReduceInto 5741 5594 -2.6% 1.03x (?)
Hanoi 20407 20220 -0.9% 1.01x (?)
HashTest 16634 17160 +3.2% 0.97x (?)
Histogram 6485 6554 +1.1% 0.99x (?)
Integrate 823 823 +0.0% 1.00x
IterateData 7864 7731 -1.7% 1.02x
Join 1104 1108 +0.4% 1.00x (?)
LazilyFilteredArrayContains 767210 789672 +2.9% 0.97x
LazilyFilteredArrays 1473728 1467377 -0.4% 1.00x (?)
LazilyFilteredRange 466202 466978 +0.2% 1.00x
LessSubstringSubstring 478 478 +0.0% 1.00x
LessSubstringSubstringGenericComparable 484 483 -0.2% 1.00x (?)
LinkedList 31925 32187 +0.8% 0.99x (?)
LuhnAlgoEager 5347 5231 -2.2% 1.02x (?)
LuhnAlgoLazy 5357 5269 -1.6% 1.02x (?)
MapReduce 27283 27340 +0.2% 1.00x (?)
MapReduceAnyCollection 27386 27313 -0.3% 1.00x
MapReduceAnyCollectionShort 39256 39250 -0.0% 1.00x (?)
MapReduceClass 31907 31936 +0.1% 1.00x (?)
MapReduceClassShort 42414 43249 +2.0% 0.98x (?)
MapReduceLazyCollection 23146 23467 +1.4% 0.99x
MapReduceLazyCollectionShort 33297 33764 +1.4% 0.99x (?)
MapReduceLazySequence 18609 18377 -1.2% 1.01x
MapReduceSequence 30508 30626 +0.4% 1.00x (?)
MapReduceShort 38865 39417 +1.4% 0.99x (?)
MapReduceString 1925 1911 -0.7% 1.01x (?)
Memset 45199 45182 -0.0% 1.00x (?)
MonteCarloE 890875 889322 -0.2% 1.00x (?)
MonteCarloPi 3866286 3851976 -0.4% 1.00x
NSStringConversion 365 365 +0.0% 1.00x
NibbleSort 295119 297464 +0.8% 0.99x (?)
NopDeinit 162258 162155 -0.1% 1.00x (?)
ObjectAllocation 1337 1375 +2.8% 0.97x
ObjectiveCBridgeFromNSArrayAnyObjectForced 8602 8918 +3.7% 0.96x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 41048 42174 +2.7% 0.97x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 35163 35325 +0.5% 1.00x (?)
ObjectiveCBridgeFromNSDictionaryAnyObject 125823 126774 +0.8% 0.99x (?)
ObjectiveCBridgeFromNSStringForced 2675 2672 -0.1% 1.00x (?)
ObjectiveCBridgeStubDataAppend 4315 4323 +0.2% 1.00x (?)
ObjectiveCBridgeStubDateMutation 630 630 +0.0% 1.00x
ObjectiveCBridgeStubFromArrayOfNSString 27605 27001 -2.2% 1.02x
ObjectiveCBridgeStubFromNSDate 5058 5061 +0.1% 1.00x (?)
ObjectiveCBridgeStubFromNSString 900 920 +2.2% 0.98x (?)
ObjectiveCBridgeStubFromNSStringRef 208 209 +0.5% 1.00x
ObjectiveCBridgeStubNSDataAppend 2900 3034 +4.6% 0.96x
ObjectiveCBridgeStubNSDateMutationRef 16182 15815 -2.3% 1.02x (?)
ObjectiveCBridgeStubToArrayOfNSString 28707 28885 +0.6% 0.99x (?)
ObjectiveCBridgeStubToNSDateRef 3478 3456 -0.6% 1.01x (?)
ObjectiveCBridgeStubToNSString 1580 1575 -0.3% 1.00x (?)
ObjectiveCBridgeStubToNSStringRef 159 159 +0.0% 1.00x
ObjectiveCBridgeStubURLAppendPath 340167 335312 -1.4% 1.01x (?)
ObjectiveCBridgeStubURLAppendPathRef 343989 343926 -0.0% 1.00x (?)
ObjectiveCBridgeToNSArray 28960 29375 +1.4% 0.99x (?)
ObjectiveCBridgeToNSDictionary 56424 54699 -3.1% 1.03x (?)
ObjectiveCBridgeToNSSet 48800 46961 -3.8% 1.04x (?)
ObjectiveCBridgeToNSString 1345 1351 +0.4% 1.00x
ObserverClosure 6310 6266 -0.7% 1.01x (?)
ObserverForwarderStruct 4393 4382 -0.3% 1.00x (?)
ObserverPartiallyAppliedMethod 7794 7829 +0.4% 1.00x (?)
ObserverUnappliedMethod 7908 7945 +0.5% 1.00x (?)
OpenClose 584 573 -1.9% 1.02x
PartialApplyDynamicType 41022 41672 +1.6% 0.98x
Phonebook 21148 20801 -1.6% 1.02x
PointerArithmetics 120252 114540 -4.8% 1.05x
PolymorphicCalls 6171 6101 -1.1% 1.01x (?)
PopFrontArray 4568 4643 +1.6% 0.98x (?)
PopFrontArrayGeneric 5783 5815 +0.6% 0.99x
PopFrontUnsafePointer 11184 11295 +1.0% 0.99x (?)
PrefixAnyCollection 13764 13601 -1.2% 1.01x (?)
PrefixAnySeqCRangeIter 16469 16736 +1.6% 0.98x (?)
PrefixAnySeqCRangeIterLazy 16344 16373 +0.2% 1.00x (?)
PrefixAnySeqCntRange 13700 13548 -1.1% 1.01x
PrefixAnySeqCntRangeLazy 13847 13802 -0.3% 1.00x
PrefixAnySequence 8914 9014 +1.1% 0.99x (?)
PrefixAnySequenceLazy 8995 8968 -0.3% 1.00x
PrefixArray 3853 3816 -1.0% 1.01x
PrefixArrayLazy 24994 25095 +0.4% 1.00x (?)
PrefixCountableRange 325 330 +1.5% 0.98x
PrefixCountableRangeLazy 26020 27148 +4.3% 0.96x (?)
PrefixSequence 8725 8684 -0.5% 1.00x
PrefixSequenceLazy 8735 8744 +0.1% 1.00x (?)
PrefixWhileAnyCollection 24986 24845 -0.6% 1.01x
PrefixWhileAnyCollectionLazy 15669 15762 +0.6% 0.99x
PrefixWhileAnySeqCRangeIter 33130 33224 +0.3% 1.00x
PrefixWhileAnySeqCRangeIterLazy 15709 15695 -0.1% 1.00x (?)
PrefixWhileAnySeqCntRange 25215 24882 -1.3% 1.01x
PrefixWhileAnySeqCntRangeLazy 15585 15976 +2.5% 0.98x
PrefixWhileAnySequence 26698 26610 -0.3% 1.00x
PrefixWhileAnySequenceLazy 9125 9094 -0.3% 1.00x
PrefixWhileArray 11644 11767 +1.1% 0.99x (?)
PrefixWhileArrayLazy 11839 12027 +1.6% 0.98x
PrefixWhileCountableRange 11674 11850 +1.5% 0.99x
PrefixWhileCountableRangeLazy 15513 15780 +1.7% 0.98x
PrefixWhileSequence 26193 26309 +0.4% 1.00x (?)
PrefixWhileSequenceLazy 8839 8873 +0.4% 1.00x (?)
Prims 9652 9667 +0.2% 1.00x (?)
PrimsSplit 9802 9619 -1.9% 1.02x (?)
QueueConcrete 13895 13970 +0.5% 0.99x
QueueGeneric 19181 19140 -0.2% 1.00x
RC4 16805 17026 +1.3% 0.99x
RGBHistogram 27253 26867 -1.4% 1.01x
RGBHistogramOfObjects 96997 97044 +0.0% 1.00x (?)
RangeIterationSigned 16520 16729 +1.3% 0.99x
RangeIterationSigned64 39292 39183 -0.3% 1.00x
RangeIterationUnsigned 34860 34775 -0.2% 1.00x (?)
RecursiveOwnedParameter 8060 7859 -2.5% 1.03x
ReversedArray 13135 13119 -0.1% 1.00x
ReversedDictionary 22893 22977 +0.4% 1.00x (?)
RomanNumbers 1165054 1123394 -3.6% 1.04x
SetExclusiveOr 17156 17113 -0.3% 1.00x (?)
SetExclusiveOr_OfObjects 41752 41526 -0.5% 1.01x (?)
SetIntersect 8267 8148 -1.4% 1.01x (?)
SetIntersect_OfObjects 12245 12057 -1.5% 1.02x
SetIsSubsetOf 1366 1344 -1.6% 1.02x
SetIsSubsetOf_OfObjects 1555 1557 +0.1% 1.00x (?)
SetUnion 11839 11848 +0.1% 1.00x (?)
SetUnion_OfObjects 29007 29012 +0.0% 1.00x (?)
Sim2DArray 43603 43613 +0.0% 1.00x (?)
SortLargeExistentials 15762 15627 -0.9% 1.01x
SortLettersInPlace 2840 2830 -0.4% 1.00x (?)
SortSortedStrings 1378 1346 -2.3% 1.02x
SortStrings 2522 2500 -0.9% 1.01x
SortStringsUnicode 16333 16372 +0.2% 1.00x (?)
StackPromo 90684 94275 +4.0% 0.96x (?)
StaticArray 2624 2612 -0.5% 1.00x (?)
StrComplexWalk 6663 6661 -0.0% 1.00x (?)
StringAdder 4754 4765 +0.2% 1.00x (?)
StringBuilder 6826 6745 -1.2% 1.01x (?)
StringBuilderLong 2745 2707 -1.4% 1.01x
StringComparison_abnormal 1457 1434 -1.6% 1.02x
StringComparison_ascii 9830 9604 -2.3% 1.02x
StringComparison_emoji 3958 3872 -2.2% 1.02x
StringComparison_fastPrenormal 13658 13288 -2.7% 1.03x
StringComparison_longSharedPrefix 13610 13075 -3.9% 1.04x
StringComparison_nonBMPSlowestPrenormal 7151 6997 -2.2% 1.02x
StringComparison_slowerPrenormal 7028 6981 -0.7% 1.01x (?)
StringComparison_zalgo 2948 2903 -1.5% 1.02x (?)
StringEdits 320371 319282 -0.3% 1.00x (?)
StringEnumRawValueInitialization 21464 21162 -1.4% 1.01x (?)
StringEqualPointerComparison 3422 3409 -0.4% 1.00x
StringFromLongWholeSubstring 22 22 +0.0% 1.00x
StringFromLongWholeSubstringGeneric 200 200 +0.0% 1.00x
StringHasPrefixAscii 3112 3032 -2.6% 1.03x
StringHasPrefixUnicode 30863 30988 +0.4% 1.00x
StringHasSuffixAscii 3230 3230 +0.0% 1.00x
StringMatch 32490 33019 +1.6% 0.98x
StringRemoveDupes 1409 1411 +0.1% 1.00x (?)
StringUTF16Builder 7652 7947 +3.9% 0.96x (?)
StringWalk 12801 12807 +0.0% 1.00x (?)
StringWordBuilder 2520 2583 +2.5% 0.98x
StringWordBuilderReservingCapacity 2168 2241 +3.4% 0.97x
SubstringComparable 4250 4248 -0.0% 1.00x (?)
SubstringEqualString 3740 3617 -3.3% 1.03x (?)
SubstringEquatable 8210 7880 -4.0% 1.04x (?)
SubstringFromLongString 24 24 +0.0% 1.00x
SubstringFromLongStringGeneric 102 103 +1.0% 0.99x
SuffixAnyCollection 4583 4533 -1.1% 1.01x
SuffixAnySeqCRangeIter 33811 33615 -0.6% 1.01x
SuffixAnySeqCRangeIterLazy 33903 33944 +0.1% 1.00x (?)
SuffixAnySeqCntRange 4585 4548 -0.8% 1.01x
SuffixAnySeqCntRangeLazy 4600 4573 -0.6% 1.01x (?)
SuffixAnySequence 25012 25193 +0.7% 0.99x (?)
SuffixAnySequenceLazy 25217 25225 +0.0% 1.00x (?)
SuffixCountableRange 111 112 +0.9% 0.99x
SuffixCountableRangeLazy 8814 9068 +2.9% 0.97x (?)
SuffixSequence 24901 25083 +0.7% 0.99x (?)
SuffixSequenceLazy 25046 25327 +1.1% 0.99x
SumUsingReduce 169418 171229 +1.1% 0.99x
SumUsingReduceInto 166445 165867 -0.3% 1.00x (?)
TwoSum 3913 3928 +0.4% 1.00x (?)
UTF8Decode 30672 31755 +3.5% 0.97x (?)
Walsh 12003 11997 -0.0% 1.00x (?)
WordCountHistogramASCII 48761 51057 +4.7% 0.96x
WordCountHistogramUTF16 107239 104743 -2.3% 1.02x (?)
WordCountUniqueASCII 7947 7921 -0.3% 1.00x (?)
WordCountUniqueUTF16 35744 34309 -4.0% 1.04x
WordSplitASCII 25925 25585 -1.3% 1.01x (?)
XorLoop 23383 23380 -0.0% 1.00x (?)
Hardware Overview 
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@xwu xwu requested a review from moiseev February 4, 2018 06:04
@airspeedswift
Copy link
Member

@swift-ci please test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Feb 5, 2018

!!! Couldn't read commit file !!!

@xwu
Copy link
Collaborator Author

xwu commented Feb 5, 2018

@swift-ci please test compiler performance

1 similar comment
@xwu
Copy link
Collaborator Author

xwu commented Feb 5, 2018

@swift-ci please test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Feb 6, 2018

Build comment file:

Summary for master full

Unexpected test results, stats may be off for FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-tvOS.log, FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-RxDataSources_generic-platform-iOS.log, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-iOS.log, FAIL_JSQDataSourcesKit-JSQDataSourcesKit.xcodeproj_4.0_BuildXcodeProjectTarget_JSQDataSourcesKit-iOS_generic-platform-iOS.log, FAIL_Dollar-Dollar.xcodeproj_3.0_BuildXcodeProjectScheme_Dollar_generic-platform-macOS.log, 3, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-macOS.log, FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-Example_generic-platform-iOS.log

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
time.swift-driver.wall 1833.1s 1808.6s -24.6s -1.34% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (1)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 965,820,565 965,920,309 99,744 0.01%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
Sema.NumConstraintScopes 11,308,754 10,951,993 -356,761 -3.15% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (22)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 1,535,203 1,535,633 430 0.03%
AST.NumLoadedModules 305,653 305,712 59 0.02%
AST.NumTotalClangImportedEntities 4,749,028 4,749,883 855 0.02%
AST.NumUsedConformances 138,312 138,325 13 0.01%
IRModule.NumIRBasicBlocks 3,013,504 3,013,549 45 0.0%
IRModule.NumIRFunctions 1,444,917 1,444,975 58 0.0%
IRModule.NumIRGlobals 1,478,505 1,478,632 127 0.01%
IRModule.NumIRInsts 30,798,635 30,798,706 71 0.0%
IRModule.NumIRValueSymbols 2,453,357 2,453,491 134 0.01%
LLVM.NumLLVMBytesOutput 965,820,565 965,920,309 99,744 0.01%
SILModule.NumSILGenFunctions 965,740 965,907 167 0.02%
SILModule.NumSILOptFunctions 1,365,753 1,365,718 -35 -0.0%
Sema.NumConformancesDeserialized 5,441,825 5,436,487 -5,338 -0.1%
Sema.NumDeclsDeserialized 44,914,876 44,829,832 -85,044 -0.19%
Sema.NumDeclsValidated 1,878,227 1,879,778 1,551 0.08%
Sema.NumFunctionsTypechecked 927,009 927,401 392 0.04%
Sema.NumGenericSignatureBuilders 1,484,932 1,478,586 -6,346 -0.43%
Sema.NumLazyGenericEnvironments 8,749,023 8,732,398 -16,625 -0.19%
Sema.NumLazyGenericEnvironmentsLoaded 818,828 811,161 -7,667 -0.94%
Sema.NumLazyIterableDeclContexts 6,953,904 6,955,884 1,980 0.03%
Sema.NumTypesDeserialized 46,793,764 46,726,809 -66,955 -0.14%
Sema.NumTypesValidated 4,430,395 4,432,888 2,493 0.06%

Debug-opt

debug-opt brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
time.swift-driver.wall 3187.9s 3069.3s -118.6s -3.72% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (1)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 942,112,353 941,425,444 -686,909 -0.07%

debug-opt detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Sema.NumConstraintScopes 11,316,936 10,946,678 -370,258 -3.27% ✅
Sema.NumLazyGenericEnvironmentsLoaded 841,131 832,314 -8,817 -1.05% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 1,536,236 1,534,455 -1,781 -0.12%
AST.NumLoadedModules 294,105 293,814 -291 -0.1%
AST.NumTotalClangImportedEntities 4,921,327 4,916,464 -4,863 -0.1%
AST.NumUsedConformances 138,413 138,229 -184 -0.13%
IRModule.NumIRBasicBlocks 3,332,674 3,330,373 -2,301 -0.07%
IRModule.NumIRFunctions 1,138,534 1,137,787 -747 -0.07%
IRModule.NumIRGlobals 1,225,484 1,224,849 -635 -0.05%
IRModule.NumIRInsts 25,527,398 25,512,992 -14,406 -0.06%
IRModule.NumIRValueSymbols 2,040,875 2,039,621 -1,254 -0.06%
LLVM.NumLLVMBytesOutput 942,112,353 941,425,444 -686,909 -0.07%
SILModule.NumSILGenFunctions 965,439 964,944 -495 -0.05%
SILModule.NumSILOptFunctions 1,889,548 1,889,056 -492 -0.03%
Sema.NumConformancesDeserialized 11,736,808 11,729,224 -7,584 -0.06%
Sema.NumDeclsDeserialized 50,981,361 50,848,066 -133,295 -0.26%
Sema.NumDeclsValidated 1,880,028 1,876,670 -3,358 -0.18%
Sema.NumFunctionsTypechecked 927,704 926,474 -1,230 -0.13%
Sema.NumGenericSignatureBuilders 1,536,192 1,527,234 -8,958 -0.58%
Sema.NumLazyGenericEnvironments 9,792,851 9,765,570 -27,281 -0.28%
Sema.NumLazyIterableDeclContexts 7,323,589 7,317,194 -6,395 -0.09%
Sema.NumTypesDeserialized 54,897,494 54,776,309 -121,185 -0.22%
Sema.NumTypesValidated 4,433,576 4,428,428 -5,148 -0.12%

Wmo-onone

wmo-onone brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 843,792,628 843,148,210 -644,418 -0.08%
time.swift-driver.wall 1372.1s 1369.7s -2.4s -0.18%

wmo-onone detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Sema.NumConstraintScopes 10,693,217 10,320,291 -372,926 -3.49% ✅
Sema.NumLazyGenericEnvironmentsLoaded 89,488 87,848 -1,640 -1.83% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 180,330 179,960 -370 -0.21%
AST.NumLoadedModules 10,335 10,295 -40 -0.39%
AST.NumTotalClangImportedEntities 569,784 568,150 -1,634 -0.29%
AST.NumUsedConformances 141,961 141,574 -387 -0.27%
IRModule.NumIRBasicBlocks 2,374,207 2,369,060 -5,147 -0.22%
IRModule.NumIRFunctions 1,198,016 1,195,643 -2,373 -0.2%
IRModule.NumIRGlobals 1,173,181 1,171,250 -1,931 -0.16%
IRModule.NumIRInsts 26,879,690 26,839,079 -40,611 -0.15%
IRModule.NumIRValueSymbols 2,003,813 2,000,069 -3,744 -0.19%
LLVM.NumLLVMBytesOutput 843,792,628 843,148,210 -644,418 -0.08%
SILModule.NumSILGenFunctions 495,108 494,431 -677 -0.14%
SILModule.NumSILOptFunctions 538,989 537,997 -992 -0.18%
Sema.NumConformancesDeserialized 1,231,227 1,222,754 -8,473 -0.69%
Sema.NumDeclsDeserialized 4,242,936 4,219,768 -23,168 -0.55%
Sema.NumDeclsValidated 859,148 858,232 -916 -0.11%
Sema.NumFunctionsTypechecked 279,945 279,567 -378 -0.14%
Sema.NumGenericSignatureBuilders 150,620 149,744 -876 -0.58%
Sema.NumLazyGenericEnvironments 725,832 721,708 -4,124 -0.57%
Sema.NumLazyIterableDeclContexts 460,937 459,537 -1,400 -0.3%
Sema.NumTypesDeserialized 4,333,595 4,311,879 -21,716 -0.5%
Sema.NumTypesValidated 1,055,290 1,054,655 -635 -0.06%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 927,151,689 926,799,878 -351,811 -0.04%
time.swift-driver.wall 3026.1s 3004.4s -21.6s -0.72%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Sema.NumConstraintScopes 10,973,784 10,619,690 -354,094 -3.23% ✅
Sema.NumLazyGenericEnvironmentsLoaded 239,577 236,158 -3,419 -1.43% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 465,191 465,193 2 0.0%
AST.NumLoadedModules 57,863 57,859 -4 -0.01%
AST.NumTotalClangImportedEntities 1,486,735 1,486,700 -35 -0.0%
AST.NumUsedConformances 144,869 145,013 144 0.1%
IRModule.NumIRBasicBlocks 2,795,204 2,793,074 -2,130 -0.08%
IRModule.NumIRFunctions 1,099,231 1,098,779 -452 -0.04%
IRModule.NumIRGlobals 1,258,113 1,257,696 -417 -0.03%
IRModule.NumIRInsts 23,435,898 23,422,745 -13,153 -0.06%
IRModule.NumIRValueSymbols 2,024,210 2,023,447 -763 -0.04%
LLVM.NumLLVMBytesOutput 927,151,689 926,799,878 -351,811 -0.04%
SILModule.NumSILGenFunctions 532,220 532,095 -125 -0.02%
SILModule.NumSILOptFunctions 961,372 960,618 -754 -0.08%
Sema.NumConformancesDeserialized 4,191,125 4,181,443 -9,682 -0.23%
Sema.NumDeclsDeserialized 13,355,864 13,330,258 -25,606 -0.19%
Sema.NumDeclsValidated 1,067,771 1,069,195 1,424 0.13%
Sema.NumFunctionsTypechecked 412,977 413,397 420 0.1%
Sema.NumGenericSignatureBuilders 466,042 463,608 -2,434 -0.52%
Sema.NumLazyGenericEnvironments 2,495,004 2,490,354 -4,650 -0.19%
Sema.NumLazyIterableDeclContexts 1,825,950 1,826,201 251 0.01%
Sema.NumTypesDeserialized 14,822,470 14,800,233 -22,237 -0.15%
Sema.NumTypesValidated 2,020,024 2,021,246 1,222 0.06%

@airspeedswift
Copy link
Member

Hi @graydon - if some test projects fail to build, do they get discounted from both runs, allowing us to still use these results as a guide?

@airspeedswift
Copy link
Member

@swift-ci please test source compatibility

moiseev
moiseev approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@moiseev moiseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

stdlib/public/core/Integers.swift.gyb
}

let hasLetters = radix > 10
let ascii: (UInt8) -> UInt8 = { digit in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be proper inner funcs instead? That would help readability a little, imo.

@graydon
Copy link
Contributor

graydon commented Feb 6, 2018 •
edited
Loading

@airspeedswift I'm afraid not, that notice is/was designed for the earlier presentation form, when we split the results by module in the comment we posted back (i.e. to tell you the reader which modules to ignore). We don't have machinery in place to automatically drop data from modules that failed; all the data aggregates into a single location and we only separate it out if asked.

It's a good idea, just hasn't been done yet (but filed: rdar://37281924)

natecook1000
natecook1000 reviewed Feb 6, 2018
View reviewed changes
stdlib/public/core/Integers.swift.gyb
@_versioned
@_transparent
internal func _description(
radix: Int = 10, uppercase: Bool = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to leave out the default values on this internal function, so we can't accidentally forget to pass on the values from the public API.

@airspeedswift
Copy link
Member

@swift-ci please smoke test compiler performance

@airspeedswift
Copy link
Member

Not sure why those particular projects failed on the compiler performance report, but I don't think the smoke version includes them so maybe that one'll be ok...

@swift-ci
Copy link
Contributor

swift-ci commented Feb 7, 2018

Build comment file:

Summary for master smoketest

Unexpected test results, stats may be off for 3

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 44,619,364 44,796,144 176,780 0.4%
time.swift-driver.wall 60.3s 60.3s -9.4ms -0.02%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 71,340 71,571 231 0.32%
AST.NumLoadedModules 10,859 10,881 22 0.2%
AST.NumTotalClangImportedEntities 197,972 198,710 738 0.37%
AST.NumUsedConformances 4,191 4,223 32 0.76%
IRModule.NumIRBasicBlocks 109,024 109,798 774 0.71%
IRModule.NumIRFunctions 60,035 60,345 310 0.52%
IRModule.NumIRGlobals 84,702 85,095 393 0.46%
IRModule.NumIRInsts 1,277,207 1,283,596 6,389 0.5%
IRModule.NumIRValueSymbols 119,598 120,184 586 0.49%
LLVM.NumLLVMBytesOutput 44,619,364 44,796,144 176,780 0.4%
SILModule.NumSILGenFunctions 76,905 77,261 356 0.46%
SILModule.NumSILOptFunctions 52,842 53,174 332 0.63%
Sema.NumConformancesDeserialized 181,601 183,093 1,492 0.82%
Sema.NumConstraintScopes 480,772 480,114 -658 -0.14%
Sema.NumDeclsDeserialized 1,383,056 1,388,574 5,518 0.4%
Sema.NumDeclsValidated 45,066 45,144 78 0.17%
Sema.NumFunctionsTypechecked 41,790 41,917 127 0.3%
Sema.NumGenericSignatureBuilders 64,442 64,519 77 0.12%
Sema.NumLazyGenericEnvironments 250,398 251,362 964 0.38%
Sema.NumLazyGenericEnvironmentsLoaded 29,526 29,491 -35 -0.12%
Sema.NumLazyIterableDeclContexts 241,303 242,226 923 0.38%
Sema.NumTypesDeserialized 1,437,580 1,444,395 6,815 0.47%
Sema.NumTypesValidated 188,866 189,107 241 0.13%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 40,835,360 40,835,352 -8 -0.0%
time.swift-driver.wall 102.0s 102.5s 566.9ms 0.56%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
Sema.NumLazyGenericEnvironmentsLoaded 3,929 3,869 -60 -1.53% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (22)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 10,387 10,387 0 0.0%
AST.NumLoadedModules 365 365 0 0.0%
AST.NumTotalClangImportedEntities 29,955 29,955 0 0.0%
AST.NumUsedConformances 4,243 4,243 0 0.0%
IRModule.NumIRBasicBlocks 89,471 89,471 0 0.0%
IRModule.NumIRFunctions 38,708 38,708 0 0.0%
IRModule.NumIRGlobals 48,555 48,555 0 0.0%
IRModule.NumIRInsts 862,004 862,004 0 0.0%
IRModule.NumIRValueSymbols 77,693 77,693 0 0.0%
LLVM.NumLLVMBytesOutput 40,835,360 40,835,352 -8 -0.0%
SILModule.NumSILGenFunctions 21,816 21,816 0 0.0%
SILModule.NumSILOptFunctions 28,213 28,213 0 0.0%
Sema.NumConformancesDeserialized 94,635 94,635 0 0.0%
Sema.NumConstraintScopes 452,845 450,005 -2,840 -0.63%
Sema.NumDeclsDeserialized 200,630 200,341 -289 -0.14%
Sema.NumDeclsValidated 28,387 28,387 0 0.0%
Sema.NumFunctionsTypechecked 11,257 11,257 0 0.0%
Sema.NumGenericSignatureBuilders 7,726 7,700 -26 -0.34%
Sema.NumLazyGenericEnvironments 32,867 32,807 -60 -0.18%
Sema.NumLazyIterableDeclContexts 20,702 20,713 11 0.05%
Sema.NumTypesDeserialized 233,091 232,884 -207 -0.09%
Sema.NumTypesValidated 56,831 56,831 0 0.0%

@xwu
Copy link
Collaborator Author

xwu commented Feb 7, 2018 •
edited
Loading

Cool.

Since this PR has had hours and hours of testing, I'll go ahead and merge if it's OK with all. Then, I'll address the reviewer points in a follow-up PR which shouldn't require nearly as much testing.

@airspeedswift
Copy link
Member

ok by me!

@xwu xwu merged commit 22da6dd into swiftlang:master Feb 7, 2018
@xwu xwu deleted the itoa branch February 7, 2018 03:35
@xwu xwu mentioned this pull request Feb 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecook1000 natecook1000 natecook1000 left review comments

@moiseev moiseev moiseev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xwu @swift-ci @airspeedswift @graydon @moiseev @natecook1000