Skip to content

[Runtime] Enable -Wall for the builds. #14417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Conversation

dcci
Copy link
Member

@dcci dcci commented Feb 5, 2018

This helps catching trivial mistakes & UB, e.g. uninitialized
booleans, see, e.g. #14400

Verified this now triggers on, e.g. SwiftRemoteAST.

[1/2] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++   -DCMARK_STATIC_DEFINE -DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/RemoteAST -I/Users/dcci/work/swift/swift/lib/RemoteAST -Iinclude -I/Users/dcci/work/swift/swift/include -I/Users/dcci/work/swift/llvm/include -I/Users/dcci/work/swift/build/Ninja-RelWithDebInfoAssert/llvm-macosx-x86_64/include -I/Users/dcci/work/swift/build/Ninja-RelWithDebInfoAssert/llvm-macosx-x86_64/tools/clang/include -I/Users/dcci/work/swift/llvm/tools/clang/include -I/Users/dcci/work/swift/cmark/src -I/Users/dcci/work/swift/build/Ninja-RelWithDebInfoAssert/cmark-macosx-x86_64/src -Wno-unknown-warning-option -Werror=unguarded-availability-new -fno-stack-protector -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics -Werror=switch -Wdocumentation -Wimplicit-fallthrough -Wunreachable-code -Woverloaded-virtual -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -O2  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk   -UNDEBUG  -fno-exceptions -fno-rtti -target x86_64-apple-macosx10.9 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -arch x86_64 -F /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/../../../Developer/Library/Frameworks -mmacosx-version-min=10.9 -O2 -g -UNDEBUG -DSWIFT_ENABLE_RUNTIME_FUNCTION_COUNTERS -MD -MT lib/RemoteAST/CMakeFiles/swiftRemoteAST.dir/RemoteAST.cpp.o -MF lib/RemoteAST/CMakeFiles/swiftRemoteAST.dir/RemoteAST.cpp.o.d -o lib/RemoteAST/CMakeFiles/swiftRemoteAST.dir/RemoteAST.cpp.o -c /Users/dcci/work/swift/swift/lib/RemoteAST/RemoteAST.cpp

I'm not a build system expert, so, if this needs to be implemented in a different way (or extended), please let me know.

This helps catching trivial mistakes & UB, e.g. uninitialized
booleans, see, e.g. swiftlang#14400
@dcci
Copy link
Member Author

dcci commented Feb 5, 2018

@swift-ci please test

Copy link
Contributor

@gparker42 gparker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold. We want at most one of #14415 and #14417.

@dcci
Copy link
Member Author

dcci commented Feb 6, 2018

@gparker42 this passed CI, can you please review/merge it?

@gparker42 gparker42 merged commit 3df5928 into swiftlang:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants