[DeclChecker] Don't try to derive conformances for invalid enums #14419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one of the cases is invalid, let's mark parent enum as invalid as well, and avoid trying to derive any conformances related to it. Resolves: rdar://problem/36989792
|
/cc @DougGregor Can you please take a look? |
|
Do we have to leave out the type, or would it be possible to mark it invalid without that? Would slightly improve the experience to still have a valid type around…but only if it's not going to lead to more crashes. |
…e names We want to preserve as much of the AST as possible in the valid state, so for cases with duplicate names it makes sense to mark declaration itself and its parent enum as invalid and leave the original types in place.
|
@jrose-apple Right! It looks like setting the type to |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the cases is invalid, let's mark parent enum as invalid
as well, and avoid trying to derive any conformances related to it.
Resolves: rdar://problem/36989792