[4.1] Fix SR-6837 - allow function conversion for -swift-version 4 *only* #14455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudkx
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
We inadvertantly allowed a function conversion for Swift 4 that we did not intend to allow. This commit adds an extremely narrow fix to continue to allow this for -swift-verson 4 only. Fixes rdar://problem/36875195 / https://bugs.swift.org/browse/SR-6837 (cherry picked from commit 1de9897)
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test source compatibility |
2 similar comments
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please nominate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We broke compatibility with something we did not intend to support, but accidentally did, in Swift 4 (and had previously in Swift 3).
Scope of Issue: In some cases we allowed functions taking an N-tuple to be passed where functions taking N individual arguments were expected.
Origination: A change was made to make function types more consistent, to avoid exactly this kind of "emergent behavior".
Risk: The fix here is very targeted, so the risk seems low.
Bug: rdar://problem/36875195 / https://bugs.swift.org/browse/SR-6837
Reviewed By: Doug Gregor
Testing: Regression tests and source compatibility testing.