Skip to content

[5.0] Fix SR-6837 - allow function conversion for -swift-version 4 *only* #14457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Feb 7, 2018

We inadvertantly allowed a function conversion for Swift 4 that we did
not intend to allow.

This commit adds an extremely narrow fix to continue to allow this for
-swift-verson 4 only.

Fixes rdar://problem/36875195 / https://bugs.swift.org/browse/SR-6837

(cherry picked from commit 1de9897)

We inadvertantly allowed a function conversion for Swift 4 that we did
not intend to allow.

This commit adds an extremely narrow fix to continue to allow this for
-swift-verson 4 only.

Fixes rdar://problem/36875195 / https://bugs.swift.org/browse/SR-6837

(cherry picked from commit 1de9897)
@rudkx rudkx changed the title Fix SR-6837 - allow function conversion for -swift-version 4 *only* [5.0] Fix SR-6837 - allow function conversion for -swift-version 4 *only* Feb 7, 2018
@rudkx
Copy link
Contributor Author

rudkx commented Feb 7, 2018

@swift-ci Please smoke test

@rudkx rudkx merged commit 43c56b3 into swiftlang:swift-5.0-branch Feb 7, 2018
@rudkx rudkx deleted the fix-sr6837-5.0 branch February 7, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant