Skip to content

[Syntax] Introduce CodeBlockItem #14458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Feb 7, 2018

CodeBlockItem represents Decl, Stmt or Expr that optionally followed by
semi-colon. It typically appears in function body or top level.
SourceFile syntax holds a list of CodeBlockItem.

Removed TopLevelCodeDecl and StmtList.

#49479

CodeBlockItem represents Decl, Stmt or Expr that optionally followed by
semi-colon.
SourceFile syntax holds a list of CodeBlockItem.
@rintaro
Copy link
Member Author

rintaro commented Feb 7, 2018

@swift-ci Please smoke test

@rintaro rintaro requested a review from nkcsgexi February 7, 2018 09:38
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Factoring semi-colon out is a good idea 👍

@rintaro rintaro merged commit 6c0af2a into swiftlang:master Feb 8, 2018
@rintaro rintaro deleted the syntax-codeblockitem branch February 8, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants