[4.1][CSSolver] Increment score when performing certain function conversions #14464
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
Build failed |
Increase solution score when performing function conversions where only one side has `@autoclosure`. That is going to help pick the best overload when only difference lays in presence of such attribute. e.g. ```swift func foo(_: @autoclosure () -> Int) {} func foo(_: () -> Int) {} ``` If the argument is itself `@autoclosure` it's preferable to use overload with `@autoclosure` attribute, otherwise `() -> Int` should be used. Resolves: rdar://problem/37160679 (cherry picked from commit 8316353)
xedin
force-pushed
the
rdar-37160679-4.1
branch
from
ff42397 to
8d6f1f2
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test source compatibility |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Explanation: Increase solution score when performing function conversions where only
one side has
@autoclosure. That is going to help pick the best overloadwhen only difference lays in presence of such attribute.
e.g.
If the argument is itself
@autoclosureit's preferable to use overloadwith
@autoclosureattribute, otherwise() -> Intshould be used.• Scope of Issue: Affects matching of the arguments to parameters marked with
@autoclosureattributes.• Origination: Caused by the attempt to fix nil coalescing operator to support optional closures.
• Risk: Low risk; Fixes a bug in constraint solver.
• Reviewed By: @rudkx
• Testing: Compiler regression tests
• Radar / SR: rdar://problem/37160679
Resolves: rdar://problem/37160679
(cherry picked from commit 8316353)