Skip to content

Re-apply "SwiftSyntax: Teach SwiftSyntax to use SourceKitd to serialize syntax trees. (#14424)" #14465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 8, 2018
Merged

Re-apply "SwiftSyntax: Teach SwiftSyntax to use SourceKitd to serialize syntax trees. (#14424)" #14465

merged 8 commits into from
Feb 8, 2018

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Feb 7, 2018

No description provided.

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 7, 2018

@swift-ci please smoke test

@xedin
Copy link
Contributor

xedin commented Feb 7, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 7, 2018

@swift-ci please test source compatibility

1 similar comment
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 7, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 7, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 7, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2018

Build failed
Swift Test OS X Platform
Git Sha - b68deb0

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2018

Build failed
Swift Test Linux Platform
Git Sha - 03a00ed

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2018

Build failed
Swift Test OS X Platform
Git Sha - 03a00ed

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test source compatibility

1 similar comment
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci Please clean test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2018

Build failed
Swift Test OS X Platform
Git Sha - 03a00ed

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2018

Build failed
Swift Test Linux Platform
Git Sha - 03a00ed

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2018

Build failed
Swift Test Linux Platform
Git Sha - a5a58f8

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

@swift-ci Please test OS X platform

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2018

Build failed
Swift Test OS X Platform
Git Sha - a5a58f8

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 8, 2018

All tests passed. 🚢

@nkcsgexi nkcsgexi merged commit f8c77e1 into swiftlang:master Feb 8, 2018
@nkcsgexi nkcsgexi deleted the re-apply-sourcekit-client-swift branch February 8, 2018 23:11
@DougGregor
Copy link
Member

Testing for the source compatibility suite is broken with

/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite/swift/tools/SwiftSourceKitClient/SourceKitdClient.swift:15:8: error: no such module 'sourcekitd'
import sourcekitd
       ^

I think it might be a missing dependency somewhere.

DougGregor added a commit to DougGregor/swift that referenced this pull request Feb 9, 2018
@DougGregor
Revert "Re-apply "SwiftSyntax: Teach SwiftSyntax to use SourceKitd to…
774bee2 
… serialize syntax trees. (swiftlang#14424)" (swiftlang#14465)"

This reverts commit f8c77e1.
@DougGregor
Copy link
Member

@nkcsgexi , I had to revert this and #14497 in #14499, because the source compatibility suite testing was broken with the error above. Sorry :(

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 9, 2018

@DougGregor thank you for reverting! I remember I've tested the source compatibility suite and the tests passed : (
I'll take a look today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkcsgexi @xedin @swift-ci @DougGregor